docs,tests: Clarify how py_wheel.strip_path_prefixes works; add test case #3027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougthor42
commented
Jun 25, 2025
rickeylev
approved these changes
Jun 25, 2025
+ test cases + docstring + formatting + types
|
@dougthor42 For reference, once approved you can merge when you're ready. Usually the approver will merge if it LGTM upon approval and it seems obviously clear things are ready. Otherwise, we approve and let the author merge when they're ready (it's not always clear when the author is done fixing, or the approver may not come back and look for days). |
|
Yup, understood. I pushed last night and then went directly to bed, haha. I didn't want to wait for CI or for a merge commit (thanks for the merge commit, btw). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a minor change to
arcname_fromto support cases wherethe distribution_prefix is the empty string.
Fixes #3017