fix(gazelle) Update gazelle to properly process multi-line python imports #3077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougthor42
reviewed
Jul 12, 2025
There was a problem hiding this comment.
Thanks! I'm somewhat surprised that the underlying tree-sitter parser doesn't handle this.
I know you already have the go tests, but lets also add a test case to gazelle/python/testdata/from_imports/imports_nested_var/__init__.py:
# baz is a variable in foo/bar/baz.py
from foo.bar.baz import baz
+
+from foo\
+ .bar.\
+ baz import (
+ baz
+ )Given that this is the same import as the previous line, the BUILD.out shouldn't change.
dougthor42
reviewed
Jul 12, 2025
|
@dougthor42 Thanks for the review! Can you take another look? |
dougthor42
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A python import may be imported as:
However, gazelle fails to resolve this import with the error:
line 30: "foo.bar.application.pipeline.model\\\n pipeline.mode.Baz" is an invalid dependency:Clean up the imports such that whitespace and \n are removed from the import path.