Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Check return code of zstd make #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2022
Merged

Check return code of zstd make #695

merged 2 commits into from
May 3, 2022

Conversation

jameskuszmaul-brt
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

If the attempt to build zstd locally fails, the error is hidden and somewhat non-obvious (it results in the tar extract failing). This can happen if, e.g., make is not installed on the local system.

Issue Number: N/A

What is the new behavior?

If the make command fails, prints the stderr of that make command to the console.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

google-cla bot commented May 2, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

f0rmiga
f0rmiga approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@f0rmiga f0rmiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@f0rmiga f0rmiga merged commit bd1a78d into bazel-contrib:main May 3, 2022
@jameskuszmaul-brt jameskuszmaul-brt deleted the zstd_make_error branch May 3, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f0rmiga f0rmiga f0rmiga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameskuszmaul-brt @f0rmiga