chore: remove bazelrc presets #247
Merged
+0
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These came from bazel-lib, which is removing them for 3.0. If we want to restore the behavior for this example, we could use the replacement https://github.com/bazel-contrib/bazelrc-preset.bzl
p0deje
approved these changes
Jul 16, 2025
Member
p0deje
left a comment
There was a problem hiding this comment.
The main reason was to ensure rules_ruby work with correctness flags (--incompatible_strict_action_env) so I'd prefer to keep this in place. However, since the ruleset is tested across multiple Bazel versions on BCR, this used to cause issues in the past.
Collaborator
Author
|
We could run with Ultimately BCR presubmit will yell at us about some flags as well, though I'm not sure if incompatible_strict_action_env is one of them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These came from bazel-lib, which is removing them for 3.0. If we want to restore the behavior for this example, we could use the replacement https://github.com/bazel-contrib/bazelrc-preset.bzl - let me know if you'd like me to do that