Add support for config_settings in target_compatible_with#29475
Open
keith wants to merge 1 commit into
Open
Conversation
fmeum
approved these changes
May 5, 2026
fmeum
approved these changes
May 5, 2026
katre
approved these changes
May 5, 2026
Collaborator
katre
left a comment
There was a problem hiding this comment.
This is great, thanks very much!
5b2c727 to
d42edc7
Compare
Previously you could only put constraint_values directly in
target_compatible_with. Therefore for other configs you had to do
something like:
```bzl
target_compatible_with = select({
":my_config_setting": [],
"//conditions:default": ["@platforms//:incompatible"],
})
```
Now you can inline that just like config settings:
```bzl
target_compatible_with = [":my_config_setting"],
```
Fixes bazelbuild#21857
d42edc7 to
9f3190f
Compare
katre
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously you could only put constraint_values directly in
target_compatible_with. Therefore for other configs you had to do
something like:
Now you can inline that just like config settings:
Fixes #21857