sandbox: Allow UNIX sockets on macOS even when block-network is used.#3444
sandbox: Allow UNIX sockets on macOS even when block-network is used.#3444philwo wants to merge 1 commit into
Conversation
|
Amazing!!! The test passes, thanks :) |
|
Scratch that. Take the time for the API you think is appropriate. Didn't
mean to stress it.
…On Mon, 24 Jul 2017 at 23:49 Philipp Wollermann ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#3444
Commit Summary
- sandbox: Allow UNIX sockets on macOS even when block-network is used.
File Changes
- *M*
src/main/java/com/google/devtools/build/lib/sandbox/DarwinSandboxedSpawnRunner.java
<https://github.com/bazelbuild/bazel/pull/3444/files#diff-0> (1)
Patch Links:
- https://github.com/bazelbuild/bazel/pull/3444.patch
- https://github.com/bazelbuild/bazel/pull/3444.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3444>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUIF0yz6rdaBQGFhMh4eaXleByS3QM-ks5sRQM7gaJpZM4OhuIu>
.
|
|
@ulfjack On macOS we don't have network virtualization, so "block-network" on that platform is used to block access to external networks in order to not accidentally depend on non-hermetic resources. We do allow networking with non-virtualized localhost though. I'd argue that just allowing UNIX sockets fits into the current philosophy and that we don't need a special flag for this. What do you think? |
|
Thanks! Importing and sending for internal review now. |
|
Fix merged internally. |
|
Yay! Thanks.
So if it went that smoothly then any chance this will be cherry picked?
…On Tue, 25 Jul 2017 at 13:14 Philipp Wollermann ***@***.***> wrote:
Fix merged internally.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3444 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUIFyS7bAOFYSNk01HJhEEf3k35d9ZAks5sRb_2gaJpZM4OhuIu>
.
|
|
I'll kindly ask @buchgr, but I don't know in what state we currently are with the 0.5.3 release :) |
|
@ittaiz This was cherry-picked and will be part of the next Bazel 0.5.3 release candidate. |
Closes #3444. PiperOrigin-RevId: 163047183
|
Just triggered the creation of the next release candidate with this change :) |
|
Thanks!
…On Wed, 26 Jul 2017 at 17:42 Jakob Buchgraber ***@***.***> wrote:
Just triggered the creation of the next release candidate with this change
:)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3444 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUIF-kbpUXE8LxAR23xji65cjUlrbmDks5sR1BkgaJpZM4OhuIu>
.
|
Closes bazelbuild#3444. PiperOrigin-RevId: 163047183
No description provided.