Update the rules_webtesting version in each submodule #503
Conversation
…bazel-common to bazel center registry.
|
we can remove the local path override now as there is official release version in bazel center register. 4.0.0, and after this i can do a release for 4.0.1 and then we can remove the override entirely. |
|
My expectation is that:
The only issue with (3) would be if we ever diverge the submodules from the parent module. In that instance the BCR presubmit for the submodule would use the override which may not align with the released version. However, if we always release them as a bundle this shouldn't be a problem. |
|
PATL |
web_testing_go/MODULE.bazel
Outdated
|
|
||
| bazel_dep( | ||
| name = "rules_webtesting", | ||
| version = "0.4.0", |
There was a problem hiding this comment.
We should pin rules_webtesting to 0.4.1 in all the submodules. Otherwise we'll always be in a weird state where the submodules are one version ahead of the parent.
There was a problem hiding this comment.
But this one has not existed in bcr yet.
There was a problem hiding this comment.
They'll all come into existence at the same time, and since we use the local_path_override, that will take precedence during presubmit. Looking at rules_rust releases, they seem to be bumping all versions in one shot.
|
PTAL |
|
Please update the PR title to reflect the current state of the change. Otherwise LGTM |
|
No description provided.