Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixing brittle Host Ruby version detection. #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kigster merged 1 commit into from
Dec 31, 2019
Merged

Fixing brittle Host Ruby version detection. #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ruby/private/toolchains/ruby_runtime.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,19 @@ def _install_ruby(ctx, ruby):

def host_ruby_is_correct_version(ctx, version):
interpreter_path = ctx.which("ruby")

if not interpreter_path:
print("Can't find ruby interpreter in the PATH")
return False

ruby_version = ctx.execute(["ruby", "--version"]).stdout
version_string = "ruby %sp" % version
ruby_version = ctx.execute(["ruby", "-e", "print RUBY_VERSION"]).stdout

have_ruby_version = (version == ruby_version)

if have_ruby_version:
print("Found local Ruby SDK version '%s' which matches requested version '%s'" % (ruby_version, version))

print("Checking for version '%s' in '%s'" % (version_string, ruby_version))
return version_string in ruby_version
return have_ruby_version

def _ruby_runtime_impl(ctx):
# If the current version of ruby is correct use that
Expand Down