Fix no_std builds on nightly via no_std attribute and explicit imports #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95885e8 to
c45748c
Compare
Fixes broken no_std builds on rustc 1.62.0-nightly
|
I can confirm this change is needed, I made the same change in my own fork too. However, I used #![cfg_attr(not(feature = "std"), no_std)]That might be a better approach since this crate does intend to be used with @bbqsrc would you consider merging this? thanks. |
jul-sh
pushed a commit
to jul-sh/oak
that referenced
this pull request
Sep 9, 2022
Our PR to fix the issue upstream was merged and release, we can now remove the patch: bbqsrc/thiserror-core2#3 Patch first added in: project-oak#2931 Tracking issue: project-oak#2920
jul-sh
pushed a commit
to project-oak/oak
that referenced
this pull request
Sep 9, 2022
Our PR to fix the issue upstream was merged and release, we can now remove the patch: bbqsrc/thiserror-core2#3 Patch first added in: #2931 Tracking issue: #2920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested on rustc 1.62.0-nightly