Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test on beta catalogue API#283

Merged
ateucher merged 36 commits intomasterfrom
catalogue-api-changes
Oct 27, 2021
Merged

test on beta catalogue API#283
ateucher merged 36 commits intomasterfrom
catalogue-api-changes

Conversation

@ateucher
Copy link
Collaborator

@ateucher ateucher commented Sep 14, 2021

WIP. Changes to fix #282

@ateucher
Copy link
Collaborator Author

ateucher commented Sep 14, 2021 •
edited
Loading

To test this, you must set:

options("bcdata.catalogue_api_url" = "https://beta-catalogue.data.gov.bc.ca/api/3/")
options("bcdata.catalogue_gui_url" = "https://beta-catalogue.data.gov.bc.ca/")

This is currently set in tests/testhat/setup.R - we will need to comment that line out when this goes to production.

@ateucher
Fix bcdc_describe_feature. #282
dff7bc1 
API changes encountered for wfs/whse resources:
- record$layer_name -> resource$object_name
- record$details -> resource$details
@ateucher
factor out catalogue base url so only have to set once
0594332
@ateucher
Add make_url() to robustly construct urls
a1b5091
@ateucher
Make separate options and functions for catalogue and api base urls.
5c1f6a0
@ateucher
Fix bcdc_browse:
80536ca 
- new catalogue web page does not return a 404 so need to check for presence of record via api
- new catalogue does not allow specification of search terms in url query parameters, so a bcdc_browse call must fail if it's not a valid record
@ateucher
document
85cb018
@ateucher
Fix docs
9353a70
@ateucher
Add bcdata_avaialable and wfs_available columns in resource_df
981fc51
@ateucher
Revert getting layer name for wfs query - and throw a warning why
01b995d
@ateucher
Remove 'type' from search facets, as only one value applied to all re…
6f2afcf 
…cords
@ateucher
Start documentation of use of APIs
a61d09a
@ateucher
Fix test for search facets
4601644
@ateucher
Revert skipping xlsx tests - resources have been added to beta catalogue
fa9a277
@ateucher
remove details from record - now at resource level
fbfd2a2
@ateucher
Fix bcdc_preview: url moved from record to resource
201e096
@ateucher
Update API documentation
53ef274
@ateucher
Use bcdc_web_service_host for bcdc_get_capabilities
4c913ed
@ateucher
Update service documentation
cc55982
@ateucher
Copy link
Collaborator Author

ateucher commented Sep 21, 2021

@boshek we could consider using the new field bcdc_type in the resource tibble:

    type = safe_map_chr(x, "bcdc_type"),

See here.

It lists each resource as geographic, tabular, application, or webservice

@ateucher
Copy link
Collaborator Author

ateucher commented Sep 21, 2021

Also resource.resource_type and resource.resource_access_method

@ateucher ateucher mentioned this pull request Oct 19, 2021
Closed
@ateucher ateucher mentioned this pull request Oct 19, 2021
Closed
19 tasks
@ateucher
Copy link
Collaborator Author

ateucher commented Oct 19, 2021

/document

@ateucher
Copy link
Collaborator Author

ateucher commented Oct 19, 2021

/precompile

@boshek
Copy link
Collaborator

boshek commented Oct 19, 2021

/precompile

@ateucher ateucher marked this pull request as ready for review October 26, 2021 20:24
@ateucher ateucher requested a review from boshek October 26, 2021 20:26
boshek
boshek approved these changes Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@boshek boshek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on this! One small thing and then an idea: Is there any value in making the service_documentation.md a vignette? It could make it more discoverable.

@ateucher ateucher merged commit 0db940a into master Oct 27, 2021
@ateucher ateucher mentioned this pull request Oct 28, 2021
Open
@ateucher ateucher deleted the catalogue-api-changes branch October 26, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boshek boshek boshek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prepare for catalogue migration

2 participants

@ateucher @boshek