Fixed incorrect enquiry and submission search for contact history #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Frontend)
|
Coverage Report (Application)
|
sanjaytkbabu
approved these changes
Mar 8, 2025
kyle1morel
reviewed
Mar 10, 2025
Comment on lines
14
to
16
| getContact(contactId: string, includeActivities?: boolean): Promise<AxiosResponse> { | ||
| const params = includeActivities === undefined ? {} : { includeActivities }; | ||
| return appAxios().get(`${PATH}/${contactId}`, { params }); |
There was a problem hiding this comment.
Could default includeActivities to false?
e2b0b9e to
07cd53c
Compare
kyle1morel
approved these changes
Mar 11, 2025
07cd53c to
e63fe16
Compare
kyle1morel
reviewed
Mar 11, 2025
Comment on lines
190
to
199
| <Column | ||
| field="intakeStatus" | ||
| field="applicationStatus" | ||
| header="Activity status" | ||
| :sortable="true" | ||
| style="min-width: 150px" | ||
| /> | ||
| > | ||
| <template #body="{ data }"> | ||
| {{ 'submissionId' in data ? data.applicationStatus : data.enquiryStatus }} | ||
| </template> | ||
| </Column> |
There was a problem hiding this comment.
Sorting will not work with enquiry status here as the field will be undefined. I think the only way to get around this though is to create two separate columns, or merge the two data points into one before mounting.
4136122 to
aa7c78d
Compare
…ded removable sort for all data tables with sorting
aa7c78d to
7654460
Compare
kyle1morel
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed incorrect enquiry and submission search for contact history so that contacts with no user attachment have correct history and so that any nav created submissions are still connected to the correct contact.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments