Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implemented Breadcrumbs and other application improvements #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 25, 2025
Merged

Implemented Breadcrumbs and other application improvements #286

merged 9 commits into from
Mar 25, 2025

Conversation

qhanson55
Copy link
Contributor

@qhanson55 qhanson55 commented Mar 20, 2025 •
edited
Loading

Description

  • TODO FIX PADS-352
  • Implement Breadcrumbs and match/ routing trees, see route tree
  • Fix route navigation calls in preparation for Breadcrumbs; removing queries, fixing states/stores of components/views, and adding/removing props. Reflect changes in confirmation emails
  • Change typeStore to permitStore, fix Permit type front and back end, fix components still unnecessarily filtering permitTypes
  • Remove BackButton and any navigational equivalents
  • Improved confirmation views
  • Removed unused components and their test files
  • Replaced onMounted with onBeforeMount where it allowed

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality) PADS-460

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2025 •
edited
Loading

Coverage Report (Frontend)

Totals Coverage
Statements: 46.54% ( 3482 / 7482 )
Methods: 36.19% ( 443 / 1224 )
Lines: 54.06% ( 2031 / 3757 )
Branches: 40.3% ( 1008 / 2501 )

@github-actions GitHub Actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 43.56% ( 1389 / 3189 )
Methods: 38.08% ( 206 / 541 )
Lines: 56.29% ( 900 / 1599 )
Branches: 26.98% ( 283 / 1049 )

@slhurley
Copy link
Contributor

Breadcrumbs and everything seem fine to me from my regression testing. With the exception of User Management, erroring out if you switch roles on someone and then try to switch back OR revoke them and try to re-add them. This was addressed in PADS-438/pr-247 in January...(as well as the auto-save scroll to top problem that has resurfaced).

@Subin1Doo
Copy link

Proponents side looks good to me! Can we just hide the breadcrumb on the 'Housing' page? There's no point of showing it when there's no path to show. Navigator side - looks like it's still getting worked on? The origin of the breadcrumb is also set to 'Housing' here, it should be 'submissions.'

@qhanson55 qhanson55 force-pushed the feature/breadcrumbs branch from ca903c8 to 5ca15e3 Compare March 24, 2025 20:57
@qhanson55 qhanson55 marked this pull request as ready for review March 24, 2025 20:58
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 24, 2025
View reviewed changes
@qhanson55 qhanson55 force-pushed the feature/breadcrumbs branch from 8e6e675 to 050c95d Compare March 24, 2025 21:25
kyle1morel
kyle1morel reviewed Mar 24, 2025
View reviewed changes
frontend/src/components/common/Breadcrumb.vue Outdated
import type { MenuItem } from 'primevue/menuitem';
import type { ComputedRef } from 'vue';
import type { RouteLocationMatched, RouteRecordNameGeneric, RouteRecordRaw } from 'vue-router';
import { storeToRefs } from 'pinia';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import ordering

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

frontend/src/components/common/Breadcrumb.vue Outdated
Comment on lines 78 to 79
case 'contact': {
return 'Contact details';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no dynamic data here. Can this contact bit be moved directly to the router?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@qhanson55 qhanson55 force-pushed the feature/breadcrumbs branch from 3d12d4c to 17d6c0c Compare March 24, 2025 23:25
@qhanson55 qhanson55 force-pushed the feature/breadcrumbs branch from 17d6c0c to 2e58a01 Compare March 24, 2025 23:30
@kyle1morel kyle1morel merged commit 5ec5e8b into master Mar 25, 2025
19 checks passed
@kyle1morel kyle1morel deleted the feature/breadcrumbs branch March 25, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jujaga jujaga jujaga approved these changes

@kyle1morel kyle1morel kyle1morel approved these changes

@sanjaytkbabu sanjaytkbabu Awaiting requested review from sanjaytkbabu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qhanson55 @slhurley @Subin1Doo @jujaga @kyle1morel