Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add korean(ko) localization #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2022
Merged

add korean(ko) localization #267

merged 1 commit into from
May 22, 2022

Conversation

gsp2101
Copy link

@gsp2101 gsp2101 commented Apr 4, 2022

add korean localization

{
  "@@locale": "ko",
  "backButtonTooltip": "뒤로",
  "closeButtonLabel": "닫기",
  "searchLabel": "검색",
  "closeNavigationTooltip": "네비게이션 닫기",
  "openNavigationTooltip": "네비게이션 열기",
  "clickToSearch": "검색",
  "modalBarrierDismissLabel": "취소",
  "minimizeWindowTooltip": "최소화",
  "restoreWindowTooltip": "이전크기",
  "closeWindowTooltip": "창닫기",
  "dialogLabel": "대화상자",
  "cutActionLabel": "잘라내기",
  "copyActionLabel": "복사",
  "pasteActionLabel": "붙여넣기",
  "selectAllActionLabel": "전체선택",
  "newTabLabel": "새탭",
  "closeTabLabelSuffix": "탭닫기",
  "scrollTabBackwardLabel": "이전탭",
  "scrollTabForwardLabel": "다음탭",
  "noResultsFoundLabel": "결과없음",
  "copyActionTooltip": "클립보드로 복사",
  "cutActionTooltip": "클립보드로 잘라내기",
  "pasteActionTooltip": "클립보드로 붙여넣기",
  "selectAllActionTooltip": "전체선택"
}

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have added/updated relevant documentation

Copy link
Contributor

@henry2man henry2man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving the fact that I don't know Korean😅, this LGTM!

Copy link
Collaborator

@WinXaito WinXaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know Korean too, so ok to me 😄

@@ -196,16 +197,13 @@ class DefaultFluentLocalizations extends S implements FluentLocalizations {
/// This method is typically used to create a [LocalizationsDelegate].
/// The [FluentApp] does so by default.
static Future<FluentLocalizations> load(Locale locale) {
return SynchronousFuture<FluentLocalizations>(
DefaultFluentLocalizations._defaultFluentLocalizations(locale));
return SynchronousFuture<FluentLocalizations>(DefaultFluentLocalizations._defaultFluentLocalizations(locale));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check formatting

}

static const LocalizationsDelegate<FluentLocalizations> delegate =
_FluentLocalizationsDelegate();
static const LocalizationsDelegate<FluentLocalizations> delegate = _FluentLocalizationsDelegate();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check formatting

@henry2man henry2man mentioned this pull request Apr 5, 2022
14 tasks
@henry2man

This comment was marked as duplicate.

Copy link
Contributor

@henry2man henry2man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update README.md supported languages list

@rk0cc
Copy link
Contributor

rk0cc commented May 22, 2022

@bdlukaa please review this pull request since it opened almost 2 months ago and still not merged yet.

@bdlukaa
Copy link
Owner

bdlukaa commented May 22, 2022

@rk0cc tests are failing. i cant merge while tests are failing

@rk0cc rk0cc mentioned this pull request May 22, 2022
3 tasks
bdlukaa added a commit that referenced this pull request May 22, 2022
@bdlukaa bdlukaa merged commit 32ec2aa into bdlukaa:master May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants