-
-
Notifications
You must be signed in to change notification settings - Fork 486
add korean(ko) localization #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving the fact that I don't know Korean😅, this LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know Korean too, so ok to me 😄
@@ -196,16 +197,13 @@ class DefaultFluentLocalizations extends S implements FluentLocalizations { | |||
/// This method is typically used to create a [LocalizationsDelegate]. | |||
/// The [FluentApp] does so by default. | |||
static Future<FluentLocalizations> load(Locale locale) { | |||
return SynchronousFuture<FluentLocalizations>( | |||
DefaultFluentLocalizations._defaultFluentLocalizations(locale)); | |||
return SynchronousFuture<FluentLocalizations>(DefaultFluentLocalizations._defaultFluentLocalizations(locale)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check formatting
} | ||
|
||
static const LocalizationsDelegate<FluentLocalizations> delegate = | ||
_FluentLocalizationsDelegate(); | ||
static const LocalizationsDelegate<FluentLocalizations> delegate = _FluentLocalizationsDelegate(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check formatting
This comment was marked as duplicate.
This comment was marked as duplicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update README.md supported languages list
@bdlukaa please review this pull request since it opened almost 2 months ago and still not merged yet. |
@rk0cc tests are failing. i cant merge while tests are failing |
add korean localization
Pre-launch Checklist
CHANGELOG.md
with my changes