Fix exception in shape_solvers_for_html when objective column has all nan values - #565
Conversation
|
I believe this happened because I had a solver that would always raise an error, even with |
|
Thanks @ogrisel for reporting this bug! I was able to reproduce with a solver that instead results in an That being said, could you pls share the benchmark that reproduces that to investigate the problem further? |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #565 +/- ##
==========================================
- Coverage 54.26% 54.23% -0.04%
==========================================
Files 43 43
Lines 2823 2825 +2
Branches 516 517 +1
==========================================
Hits 1532 1532
- Misses 1176 1178 +2
Partials 115 115 |
|
This was on the benchopt/benchmark_logreg_l2 I think, with the new solver from the PR @ogrisel proposed. |
|
I did a bunch of ctrl c manually and it was in a dev branch of scikit-learn so i don't think i would know the exact conditions to reproduce it. |
As observed in one case with @tomMoral this afternoon.
Here is the full traceback: