refactor: optimise parser for performance #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, will have a look at this soon!
Appreciated, I'm happy to have typings included but I'm more hesitant to take on the burden of having to transpile. |
|
Have you had time to check this out? Regards TS, I think it then makes sense to just skip typing this package, if there is a need, a package can be added to DefinitelyTyped. |
|
Sorry not yet but should get to it this week |
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
It is not verbatim copy of the TS version of the parser we wrote, as I didn't want to convert this package to typescript (let me know if you think that's still valid and OK to do).
It also handles infinity slightly differently (we chose to go with always returning a Date object, instead of returning either date or number) than the package mentioned in the issue.
The performance gains should still be there though.