Track uninitialized setters #291
Conversation
I believe this preserves the intent and semantics of PR benjamn#291, but with a slightly simpler mechanism for obtaining any newly added setter keys without iterating over all existing setters.
There was a problem hiding this comment.
@zodern Thanks for bringing this idea back as a separate PR, and sorry for the long wait!*
Please give my refactoring a look and let me know if it preserves your intentions. Also, I'm imagining my changes will be performance-neutral, but you might want to run your measurements again, just to be sure.
If everything looks good to you, I'm happy to release this tomorrow/soon!
* If I'm being honest, it took me a few weekend attempts to get fully back into the context of this codebase, which certainly wasn't helped by the lack of TypeScript types. If you (or anyone else) has an interest in converting this codebase to TypeScript (and using tsc to transpile it all the way back to pre-const ES5), I'm definitely open to that.
|
@benjamn the changes look good, and the performance is similar. If I create any more PR's I will consider adding types. |
I believe this preserves the intent and semantics of PR #291, but with a slightly simpler mechanism for obtaining any newly added setter keys without iterating over all existing setters.
|
@zodern I've published these changes in |
Re-implements one of the optimizations from #246 that was removed.
Reduces the time spent by
runSetterswhen runningimport { Web, Add } from '@material-ui/icons/esm/index.js';from ~15-20 seconds down to less than 1. In the Svelte example, this would reduce the time spent byrunSettersto around 4ms from the current 32ms.