-
-
Notifications
You must be signed in to change notification settings - Fork 50
Expose all of nodemailer’s transport settings using a new transportConfig configuration subkey #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nfig configuration subkey All known documentation has been updated to expose host and port below this new key. Existing configuration continues to work but shows a warning on startup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @ntninja !
I'm not interested in adding this deprecation and change, unless there's some very specific need/request for it. Could you elaborate on what it is?
Ideally and eventually, I'd like to move away from nodemailer, because SMTP is not that complicated and these emails are very simple, so binding the config to that dependency is something I'm not very willing to do.
Additionally, before I'd accept a utility function like that, it would have to be in misc utils, have explicit types, and tests.
|
Regarding your NixOS module, I'm happy to accept a PR with a new "Community links" section in the main README which links to it. |
In my case I needed the I think your underestimating the complexity of real-world mail deployments, SMTP being “simple” just means that all the complexity ends up in the configuration/deployment options of client (hence why setting up mail clients is often a pain) and getting anything to work particularily with custom mail clients is always a huge pain in the a** – for instance Had I had the fully
Thought so, wanted to wait for review and feature agreement before I throw time at time though. |
|
Thanks for all the details! Given all of the above, I'd accept a new configuration option |
As requested in bewcloud#125 (comment).
|
I see, I might end up pestering you for more options then. Will make a new PR once I implemented that! |
* Add reference to `bewcloud-nixos` to README.md As requested in #125 (comment). * Add suggestion * Add suggestion --------- Co-authored-by: Bruno Bernardino <[email protected]>
All known documentation has been updated to expose host and port below this new key. Existing configuration continues to work but shows a warning on startup.
I’ve also published a (Docker-less) NixOS integration module for bewCloud at https://gitlab.com/ntninja/bewcloud-nixos/. (Currently still targeting NixOS 25.05, since I’m not able to upgrade as NixOS 25.11 dropped some software – including Seafile, which is what caused me to look for alternatives that don’t revel in being a maintainers nightmare to begin with.)