Remove all uses of Google Services #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better would be to use https://www.mediawiki.org/wiki/GeoHack – which is used by WikiPedia to show an interactive selector for the mapping service to use –, but it requires geo coordinates. Some systems also support generic geo:-URIs, but they require coodinates and outside Android support is pretty spotty (Apple wants you to use Apple Maps links instead, desktop platforms generally require installed third-party apps …). Android does support an extension (`?q=`) (https://developer.android.com/guide/components/intents-common#Maps) to search by address via geo:-links though.
Member
|
Thank you, this looks good and is more than enough! |
Member
|
This is now available in v3.2.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ad 2) Some considerations:
Better would be to use https://www.mediawiki.org/wiki/GeoHack – which is used by WikiPedia to show an interactive selector for the mapping service to use –, but it requires geo coordinates. Some systems also support generic geo:-URIs, but they require coodinates and outside Android support is pretty spotty (Apple wants you to use Apple Maps links instead, desktop platforms generally require installed third-party apps …). Android does support an extension (
?q=) (https://developer.android.com/guide/components/intents-common#Maps) to search by address via geo:-links though.Technically Address-to-Coordinate search could be done using Nominatim, but I’m pretty sure you’d object to that and it isn’t clear how this should handle multiple or no search results for the given address.
Let me know what you think!