APPEX-301: fixes error with fs module import #15
Conversation
b7750b4 to
6a85020
Compare
bc-zachary
left a comment
There was a problem hiding this comment.
One clarification, but looks good otherwise! 👍
| } catch (err) { | ||
| assertIsError(err); | ||
| process.stderr.write(`${sourceFile}: ${err.name}: ${err.message}\n`); | ||
| process.stderr.write(`${sourceFile}: ${err.name}: ${err.message}}\n`); |
There was a problem hiding this comment.
Not sure if intentional. Is there an omitted closing brace in err.message?
| process.stderr.write(`${sourceFile}: ${err.name}: ${err.message}}\n`); | |
| process.stderr.write(`${sourceFile}: ${err.name}: ${err.message}\n`); |
There was a problem hiding this comment.
good catch - I was mucking around with error output (trying to resolve the issue removing the auto-gen files) and left this.
| strategy: | ||
| matrix: | ||
| node-version: [12.x, 14.x, 16.x, 17.x] | ||
| node-version: [12.x, 14.x, 16.x, 18.x] |
There was a problem hiding this comment.
🍹 Should we keep 17.x in there? I'm also wondering if we should just get rid of 12.x since it's no longer maintained (security support ended earlier this year)
There was a problem hiding this comment.
17.x isn't an LTS version and is no longer supported. I believe it reached end of life in May or June.
There was a problem hiding this comment.
17 is indeed no longer supported so I bumped this to 18. I definitely think we should look into dropping 12 - I'd like to capture that in a separate PR (I'm already a bit out of scope with removing the auto-generated types files)
matthewvolk
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for going down the rabbit hole on this one with the generated files!
What?
Fixes an issue with Node's
fs/promisesmodule import. Essentially, this issue is corrected in Node 14+ - the fix for Node 12 is to remove/promisesfrom the import.NOTE: this PR also removes the initial
npm buildfrom the generate command - this was creating issues since the types were no longer there.Tickets / Documentation
APPEX-304
Testing
verified locally by running linting
cc @bigcommerce/gta-dt