fix: APPEX-585 udpate catalog typing #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtalvarez
previously approved these changes
Jul 20, 2023
rtalvarez
approved these changes
Jul 20, 2023
bc-chaz
reviewed
Jul 21, 2023
| const remoteSourceDir = await this.client.get<GitHubRepoTree>(targetDir.url); | ||
| const specFileNames = remoteSourceDir.data.tree.map(file => `${this.CONTENT_URL}${file.path}`); | ||
|
|
||
| const specFileNames = await remoteSourceDir.data.tree.reduce( |
Contributor
There was a problem hiding this comment.
🍹 since this is a deeply nested prop, should we consider adding in optional chaining?
Contributor
Author
There was a problem hiding this comment.
I think this should be fine, based on the GIT trees api, the elements that we are chaining should be defined as either a tree type or string type👍🏼 . Reference: https://docs.github.com/en/rest/git/trees?apiVersion=2022-11-28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The Node API client is broken. Recently, breaking changes have been introduced to the API Specs repo - this has caused the Node API client to break as Catalog has been converted from a file to a directory of files.
Tickets / Documentation
APPEX-585
Testing
Updated and added unit tests
Files are generated when running npm run generate
cc @bigcommerce/gta-dt