feat(checkout): CHECKOUT-000 Add spans for product-title, product-item-quantity, product-option-label, and product-option-value #1701
+49
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-quantity, product-option-label, and product-option-value
animesh1987
reviewed
Feb 16, 2024
| @@ -37,7 +39,8 @@ const OrderSummaryItem: FunctionComponent<OrderSummaryItemProps> = ({ | |||
| className="product-title optimizedCheckout-contentPrimary" | |||
| data-test="cart-item-product-title" | |||
| > | |||
| {`${quantity} x ${name}`} | |||
| <span className="product-item-quantity">{quantity}</span> | |||
There was a problem hiding this comment.
Do we need to change this?
There was a problem hiding this comment.
Technically no. But the community elaborated, and mentioned that it's the same improvement and would be nice to be able to target qty and name separately as well. Enabling dev's to style those individually with CSS without the need to introduce JS to do so
animesh1987
reviewed
Feb 16, 2024
| @@ -46,7 +49,8 @@ const OrderSummaryItem: FunctionComponent<OrderSummaryItemProps> = ({ | |||
| > | |||
| {productOptions.map((option, index) => ( | |||
| <li className="product-option" data-test={option.testId} key={index}> | |||
| {option.content} | |||
| <span className="product-option-label">{option.optionLabel}</span> | |||
There was a problem hiding this comment.
Maybe add a check here for content, just in case for customisations? Something like
{Boolean(content) ?
{option.content} :
<>
<span className="product-option-label">{option.optionLabel}</span>
<span className="product-option-value">{option.optionValue}</span>
</>
}
There was a problem hiding this comment.
option.content is removed all together from the product options and replaced by optionLabel and optionValue
…m-quantity, product-option-label, and product-option-value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As requested by community members here, #1700
we've added wrapping spans around product quantity and product title, as well as adding wrapping spans around product options label and value in the cart-summary.
Why?
This improves customization options for developers as they can target these values now purely with CSS
Testing / Proof
@bigcommerce/team-checkout