-
Notifications
You must be signed in to change notification settings - Fork 396
feat(checkout): CHECKOUT-9454 Convert AddressForm #2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-peng
reviewed
Aug 28, 2025
bc-peng
reviewed
Aug 29, 2025
025ab9e
to
a0b34c4
Compare
a0b34c4
to
76464bb
Compare
animesh1987
reviewed
Sep 4, 2025
? getBillingCountries() | ||
: getShippingCountries()) | ||
|| EMPTY_ARRAY; | ||
const googleMapsApiKey = config?.checkoutSettings.googleMapsApiKey || ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a formatting issue?
bc-peng
previously approved these changes
Sep 5, 2025
bc-peng
approved these changes
Sep 8, 2025
checkout-js deployed to Integration US |
checkout-js deployed to Staging US |
⚡️ Lighthouse results🖥️ Desktop:
📱 Mobile:
|
checkout-js deployed to Production US |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Convert class component
AddressForm
into function component.Replacing class components with function components eliminates the need for traditional lifecycle methods and enables full adoption of React 18 features like hooks and concurrent rendering.
This modernization aligns with React’s roadmap and ensures greater compatibility with future updates.
Rollout/Rollback
Revert this PR.
Testing