refactor(checkout): CHECKOUT-9386 Remove CreditCardFieldset #2552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
animesh1987
reviewed
Sep 4, 2025
| } | ||
| }); |
There was a problem hiding this comment.
Suggested change
| }); | |
| }, []); |
There was a problem hiding this comment.
Also do we need to add deps here, since this replacing componentDidUpdate and not componentDidmount?
There was a problem hiding this comment.
In theory, [] should not be set in order to run this whenever something changes.
And we only trigger updates when inputRef.current && inputRef.current.selectionEnd !== nextSelectionEndRef.current is met.
vitalii-koshovyi
previously approved these changes
Sep 8, 2025
animesh1987
previously approved these changes
Sep 9, 2025
0004a6e
327871f to
2de5c47
Compare
2d6eb82 to
ca16b3b
Compare
bc-peng
commented
Sep 11, 2025
| @@ -260,9 +260,7 @@ const BigCommercePaymentsCreditCardsPaymentMethod: FunctionComponent<PaymentMeth | |||
| [getHostedFormOptions, initializePayment], | |||
| ); | |||
|
|
|||
| // Info: isHostedFormEnabled is an option in store config which responsible for switching BigCommercePayments Credit Card form | |||
| // rendering between Hosted Form and default BC fields (non-hosted) | |||
| return isHostedFormEnabled ? ( | |||
There was a problem hiding this comment.
Removed the branch when isHostedFormEnabled is false.
Confirmed internally this is no longer possible.
bc-peng
commented
Sep 12, 2025
| import { LoadingOverlay } from '@bigcommerce/checkout/ui'; | ||
|
|
||
| export interface CreditCardPaymentMethodProps { | ||
| cardFieldset?: ReactNode; | ||
| cardFieldset: ReactNode; |
There was a problem hiding this comment.
Make cardFieldSet required so that each payment method using <CreditCardPaymentMethodComponent /> defines its own card validation field set.
ca16b3b to
40c91b6
Compare
refactor(checkout): CHECKOUT-9386 CreditCardNumberInput
40c91b6 to
d07561f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Remove the following components:
CreditCardFieldsetCreditCardNumberFieldCreditCardValidationCreditCardExpiryFieldCreditCardNameFieldThese components were used for the non-hosted version of credit card form fields, which has since been deprecated, so they are safe to remove.
Rollout/Rollback
Revert.
Testing
CI.