refactor(checkout): CHECKOUT-9386 Convert CreditCardPaymentMethodComponent #2559
+239
−345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-peng
commented
Sep 4, 2025
|
|
||
| export default CreditCardPaymentMethodComponent; | ||
| void reInit(); | ||
| }, [selectedInstrumentId, isAddingNewCard]); |
There was a problem hiding this comment.
Removed method here. The rest of the PR is the same as #2530.
richapatel1510
approved these changes
Sep 4, 2025
vitalii-koshovyi
approved these changes
Sep 8, 2025
| @@ -11,6 +11,7 @@ | |||
| "@typescript-eslint/no-unsafe-argument": "off", | |||
| "@typescript-eslint/no-unnecessary-condition": "off", | |||
| "@typescript-eslint/consistent-type-assertions": "off", | |||
| "@typescript-eslint/naming-convention": "off" | |||
| "@typescript-eslint/naming-convention": "off", | |||
| "react-hooks/exhaustive-deps": "off" | |||
There was a problem hiding this comment.
Is it better to ignore a rule when necessary than to ignore it for the whole package?
There was a problem hiding this comment.
Moving conversation to #2562 (comment)
animesh1987
approved these changes
Sep 9, 2025
|
A quick update: I’ve attached videos of manual testing for the BlueSnap and Access Worldpay CC payment methods to the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Re-release #2530 with updated dependencies due to an incident.
Convert class component
CreditCardPaymentMethodComponentinto function component.Replacing class components with function components eliminates the need for traditional lifecycle methods and enables full adoption of React 18 features like hooks and concurrent rendering.
This modernization aligns with React’s roadmap and ensures greater compatibility with future updates.
Rollout/Rollback
Revert.
Testing
CI.
Manual Testing
Bluesnap (The CC form fields freezing is a known issue)
Screen.Recording.2025-09-10.at.14.11.36.mov
Access Worldpay
Screen.Recording.2025-09-10.at.14.25.41.mov