Advertising the ESM file with the "module" key#35
Merged
Conversation
This was referenced Jan 28, 2024
weaverryan
added a commit
to symfony/ux
that referenced
this pull request
Feb 29, 2024
…ase 🚀 (weaverryan) This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Live][Stimulus] Prepping the LiveComponent Stable Release 🚀 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Issues | None | License | MIT Hi! LiveComponents has, really, been quite stable for a long time, but it's kept its experimental status. Removing that is really about deciding that we'll protect backwards-compatibility. It's time to do that :). This is planned as the 2.15.0 release near the end of Feb (assuming we get the items below done before then). TODOs: * #1418 * Possibly remove Twig 2.x compat * #1428 * #1392 * Moving `Idiomorph` to a peer dependency would be great, but blocked by bigskysoftware/idiomorph#35 - **still need a tag** for the PR merge * #1426 as it may include some edge-case BC breaks. If there's anything else on your mind before stable, now is the time to mention it :). Cheers! Commits ------- 7932a9d [Live][Stimulus] Prepping the LiveComponent Stable Release 🚀
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Fixes #28. Using:
already works, as indicated by the README.md file. However, by adding the
modulekey, users in a module environment will simply be able to say:Additionally, some CDN's like jsdelivr package an ESM version. As you can see, the current version is an empty file - https://cdn.jsdelivr.net/npm/[email protected]/+esm - the reason being that they look for the
modulekey to know which file to use (seeLocating entry pointson jsdelivr/jsdelivr#18263 ).I am not an absolute expert on this topic, but I'm fairly confident with this PR.
Thanks!