This repository was archived by the owner on May 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/deriv/deriv-com/78zf8j3q7/binary.sx |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deriv-com-git-sean-dp2p-qr-code.binary.sx/ |
mustofa-binary
approved these changes
Nov 18, 2020
mustofa-binary
suggested changes
Nov 18, 2020
mustofa-binary
approved these changes
Nov 19, 2020
mustofa-binary
pushed a commit
that referenced
this pull request
Dec 1, 2020
* feat: add QR code and desktop copywriting * moved p2p related assets into its own folder
mustofa-binary
added a commit
that referenced
this pull request
Dec 1, 2020
* Kevin/ Add Tradertools page (calculators) (#1125) * Sara / Update commission text (#1132) * Removed up to * Removed up to from who-can-apply Co-authored-by: sara-fs <[email protected]> * Kevin/Update multiplier content (#1134) * feat:update multiplier content * fix:resolve PR comments * fix:Qa comments * fix:Qa comments #2 * fix:qa comments #3 * fix:qa issues * fix: Qa comments * update: image and fix qa comments * fix:margin problem on text * update: messages.json ( translation:extract ) Co-authored-by: Kevin <[email protected]> * fix: updated text for UK and non-UK clients (#1146) * text:update eu footer content (#1141) Co-authored-by: Kevin <[email protected]> * text:add apostrophe on option description (#1120) Co-authored-by: Kevin <[email protected]> * text: update hero content (#1139) Co-authored-by: Kevin <[email protected]> * translate:extract upload download * translate: download * translate: download chinese * amam/add_fiat_onramp (#1164) * feat: add onramp payment methods * update: hide wyre and xanpool for now Co-authored-by: mustofa-binary <[email protected]> * translate: download * feat: trader-tools-page-calculators * feat: handleError onclick for X icon * fix:PR#1 * Fix:PR comments#2 * fix:PR - make use of Flex component instead of div * fix: handle error, and buttond default disabled * Fix: Qa comments #4 & add symbols * fix: update validation text * fix:margin to show decimal if necessary * fix: minor styling * remove: unecessary duplicate validation * fix:PR comments : update validation, and styling * fix: code review * update:dropdown * fix qa comments * improve: styling and fix qa comment * fix: max 2 digit decimals input, refactor validation, calculate bug * fix: placeholder issue * fix: placeholder issue * fix: issue 35,36,37 * fix: issue 35,36,37 * remove: max 2 input decimal * resolve: qa comments * remove extra 0 on submit * fix: qa comment focus on clicked error * removed selected symbol dropdown * resize font on smaller screen * fix: different font for dropdown and input field * fix:styling of subheader calculator * add: scrollable margin value without showing scrollbar * fix: border radius and scientific annotation removal on swap calc * fix:different color in ios browser * fix:different color in ios browser * update: text area to flex * fix: dropdown label on tab change, error on mozilla, color on safari * fix: image for mobile version and remove some unused image & script * added special case for step index, range break 100,200 on margin calculation * fix: value and currency symbol alignment * refactor: major refactor * fix: image and formula * fix: backround on label input (active) and link on synthetic * fix: wrong text on swap-forex formula * fix: text content on swap-forex * fix: tab selector * fix: add color blues * fix: icons * fix: add alt on icons * fix:refactor codes Co-authored-by: sara-fs <[email protected]> Co-authored-by: sara-fs <[email protected]> Co-authored-by: Kevin <[email protected]> Co-authored-by: sean-binary <[email protected]> Co-authored-by: mustofa-binary <[email protected]> Co-authored-by: Mustofa Ghaleb Amami (Front End) <[email protected]> * Sean / fix: added KID notice (#1182) * fix: added KID notice * fix: added padding * Sean / Landing page for DP2P (#1173) * feat: [WIP]P2P landing page * fix: mobile responsiveness for P2P page * fix: navbar logo spacing for mobile * fix: background image positioning * fix: redirect links * fix: reduced image file sizes * fix: reducing media queries * Replaced mobile prop with show component * fix: button wording * fix: copyright svg color to white * revert last commit * fix: white copyright svg * fix: created v1 & v2 of DP2P page * fix: fixed console errors and paddings & margins * fix: button resizing * fix: redirect links and adding new span link text component * fix: blurry images and section margins * fix: hero font sizes and margins * fix: padding changes to reflect design * fix: issues regarding mobile paddings and margins * fix: issues with mobile design not matching * fix: added show component to handle mobile hero background * fix: redirect notice prompt * fix: mobile header center align * fix: redirecting before confirmation * fix: redirecting before confirmation for EU * fix: redirecting before confirmation for EU * fix: redirecting before confirmation for EU * fix: redirecting before confirmation for EU * fix: redirecting before confirmation for EU * fix: redirecting before confirmation for EU * revert back to 3adbc50 * replaced p2p_v1 prop to general nav_type prop Co-authored-by: Sean <[email protected]> * translate: extract upload * Sean / DP2P QR code (#1206) * feat: add QR code and desktop copywriting * moved p2p related assets into its own folder * translate: extract, upload * Matin/Add DP2P in Payment Method Page (#1204) * Matin/Add DP2P in Payment Method Page * Matin/Improvement: use Show component to separate Mobile and Desktop * Use pixel inside media queries * Matin/Fix/Improvement: Added mobileOsDetect * Fix dp2p buttons size and misalignments * Todo IOS os to redirect to apple store Co-authored-by: matin-binary <[email protected]> * translate: upload, extract dp2p payment method * fix: image alt * translate: download * translate: download chinese * translate: download fix zh cn and tw * translate: download pl * Sean/trading responsibly page not accessible (#1229) * fix: refactor using svgr syntax * Empty commit * fix: update svg * replace svg component with img element * Sean/dp2p page translatation ui (#1232) * fix: translation UI breaking * responsive button sizes for all languages * fix: translation UI breaking * fix: translation UI breaking * fix: translation UI breaking * fix: banner header size to cater all languages * translate: hotfix upload download * translate: download hotfix * feat: add p2p allowed country check for payment methods (#1239) Co-authored-by: mustofa-binary <[email protected]> * translate: download for calculator fix Co-authored-by: Kevin <[email protected]> Co-authored-by: sara-fs <[email protected]> Co-authored-by: sara-fs <[email protected]> Co-authored-by: Kevin <[email protected]> Co-authored-by: sean-binary <[email protected]> Co-authored-by: mustofa-binary <[email protected]> Co-authored-by: Sean <[email protected]> Co-authored-by: matin-binary <[email protected]> Co-authored-by: matin-binary <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
Changes:
Type of change