Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Amam/websocket page #1719

Merged
9 commits merged into from
Jun 9, 2021
Merged

Amam/websocket page #1719

9 commits merged into from
Jun 9, 2021

Conversation

mustofa-binary
Copy link
Contributor

@mustofa-binary mustofa-binary commented May 16, 2021 •
edited
Loading

Changes:

  • new endpoint page
  • refactor hooks
  • modify deriv store

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented May 16, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-com/2JvG24HtKSAmPAvQ6YLsCZqevYnL
✅ Preview: https://deriv-com-git-fork-mustofa-binary-amam-websocketpage.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2021 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 49
🟢 Accessibility 98
🟢 Best practices 93
🟠 SEO 85
🟠 PWA 75

Lighthouse ran on https://deriv-com-git-fork-mustofa-binary-amam-websocketpage.binary.sx/

@mustofa-binary mustofa-binary requested review from a user, suthesank and yashim-deriv May 17, 2021 05:54
ShuvoHabib
ShuvoHabib reviewed May 17, 2021
View reviewed changes
ghost
ghost reviewed May 17, 2021
View reviewed changes
@mustofa-binary mustofa-binary requested a review from a user May 17, 2021 10:01
ShuvoHabib
ShuvoHabib previously approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@ShuvoHabib ShuvoHabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ~

yashim-deriv
yashim-deriv reviewed May 18, 2021
View reviewed changes
Copy link
Contributor

@yashim-deriv yashim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR~ would speed up dev. Checkout the comments I left 😄

yashim-deriv
yashim-deriv previously approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@yashim-deriv yashim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

suthesank
suthesank previously approved these changes May 19, 2021
View reviewed changes
@mustofa-binary mustofa-binary dismissed stale reviews from suthesank and yashim-deriv via a021196 May 21, 2021 00:53
ghost
ghost previously approved these changes Jun 9, 2021
View reviewed changes
@mustofa-binary mustofa-binary marked this pull request as ready for review June 9, 2021 06:49
ghost
ghost approved these changes Jun 9, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 4741a1f into binary-com:master Jun 9, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ShuvoHabib ShuvoHabib ShuvoHabib left review comments

@suthesank suthesank suthesank left review comments

@yashim-deriv yashim-deriv yashim-deriv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mustofa-binary @ShuvoHabib @suthesank @yashim-deriv @cakasuma