Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Kevin/update stock indices to stocks and indices on header, footer, and market #1826

Merged
suthesank merged 2 commits into from
Jul 9, 2021
Merged

Kevin/update stock indices to stocks and indices on header, footer, and market #1826

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8526b8b
update stock indices to stocks and indices on header, footer, and market
virtualpowwa Jun 14, 2021
8780883
add dev comments
virtualpowwa Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
update stock indices to stocks and indices on header, footer, and market
  • Loading branch information
@virtualpowwa
virtualpowwa committed Jun 14, 2021
commit 8526b8b2e51812b280b67a7e83ada80723523fcb
2 changes: 1 addition & 1 deletion src/components/custom/other-platforms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ export const NavMarket = ({ onClick, is_ppc }) => (
aria_label="Stocks & indices"
icon={() => <img src={StockIndices} alt="StockIndices" width="32" height="32" />}
content={
<Localize translate_text="Predict broader market trends and diversify your risk with stock indices." />
<Localize translate_text="Predict broader market trends and diversify your risk with stocks & indices." />
}
title={<Localize translate_text="Stocks & indices" />}
onClick={onClick}
Expand Down
2 changes: 1 addition & 1 deletion src/components/elements/off-canvas-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ export const OffCanvasMenuWrapper = (props) => {
/>
)}
content={localize(
'Predict broader market trends and diversify your risk with stock indices.',
'Predict broader market trends and diversify your risk with stocks & indices.',
)}
title={localize('Stocks & indices')}
onClick={handleArrowClick}
Expand Down
2 changes: 1 addition & 1 deletion src/components/layout/footer/main-links.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const MainLinksSection = ({is_ppc, is_ppc_redirect, is_eu_country }) => {
)}
<LinkWrapper>
<Link to="/markets/stock/">
{localize('Stock indices')}
{localize('Stocks & indices')}
</Link>
</LinkWrapper>
<LinkWrapper>
Expand Down
4 changes: 2 additions & 2 deletions src/pages/home/_hero.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ const ImageWrapper = styled(Box)`
const Hero = ({ is_ppc }) => {
const data = useStaticQuery(query)
const typewriter_text = !is_ppc
? localize('Trade forex, commodities, synthetic and stock indices')
: localize('Trade forex, commodities, and stock indices')
? localize('Trade forex, commodities, synthetic and stocks & indices')
Copy link
Contributor

@suthesank suthesank Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling something needs to be changed here 😅 Shouldn't it be synthetic indices and stocks & indices?

Copy link
Contributor Author

@virtualpowwa virtualpowwa Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed this with lipika and it should be Trade forex, commodities, synthetics, and stocks & indices instead

: localize('Trade forex, commodities, and stocks & indices')
const [type_writer, setTypeWriter] = React.useState('')
const [check_first_load, setFirstLoad] = React.useState(false)
let type_writer_timeout
Expand Down
2 changes: 1 addition & 1 deletion src/pages/markets/commodities/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const CommoditiesPage = () => (
<Layout>
<SEO
description={localize(
'Learn about the markets that you can trade online with Deriv, including forex, commodities, synthetic indices, and stock indices.',
'Learn about the markets that you can trade online with Deriv, including forex, commodities, synthetic indices, and stocks & indices.',
)}
title={localize('Markets | Markets to trade | Deriv')}
/>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/markets/components/sections/_nav-tab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const tabList = [
route_to: '/markets/synthetic/',
},
{
title: <Localize translate_text="Stock indices" />,
title: <Localize translate_text="Stocks & indices" />,
tab_name: 'stock',
route_to: '/markets/stock/',
},
Expand Down
2 changes: 1 addition & 1 deletion src/pages/markets/cryptocurrencies/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const CryptocurrenciesPage = () => (
<Layout>
<SEO
description={localize(
'Learn about the markets that you can trade online with Deriv, including forex, commodities, synthetic indices, and stock indices.',
'Learn about the markets that you can trade online with Deriv, including forex, commodities, synthetic indices, and stocks & indices.',
)}
title={localize('Markets | Markets to trade | Deriv')}
/>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/markets/forex/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const ForexPage = () => (
<Layout>
<SEO
description={localize(
'Learn about the markets that you can trade online with Deriv, including forex, commodities, synthetic indices, and stock indices.',
'Learn about the markets that you can trade online with Deriv, including forex, commodities, synthetic indices, and stocks & indices.',
)}
title={localize('Markets | Markets to trade | Deriv')}
/>
Expand Down
4 changes: 2 additions & 2 deletions src/pages/markets/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ const simple_step_content_stock = [
{
header: <Localize translate_text="Trade" />,
text: (
<Localize translate_text="Open a real account, make a deposit, and start trading stock indices and other markets. " />
<Localize translate_text="Open a real account, make a deposit, and start trading stocks & indices and other markets. " />
),
icon: <img src={TradeIcon} alt="trade" width="32" height="28" />,
},
Expand Down Expand Up @@ -146,7 +146,7 @@ const Markets = () => (
<Layout>
<SEO
description={localize(
'Learn about the markets that you can trade online with Deriv, including forex, commodities, synthetic indices, and stock indices.',
'Learn about the markets that you can trade online with Deriv, including forex, commodities, synthetic indices, and stocks & indices.',
)}
title={localize('Markets | Markets to trade | Deriv')}
/>
Expand Down
4 changes: 2 additions & 2 deletions src/pages/markets/stock/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const simple_step_content_stock = [
{
header: <Localize translate_text="Trade" />,
text: (
<Localize translate_text="Open a real account, make a deposit, and start trading stock indices and other markets." />
<Localize translate_text="Open a real account, make a deposit, and start trading stocks & indices and other markets." />
),
icon: <img src={TradeIcon} alt="trade" width="32" height="28" />,
},
Expand All @@ -38,7 +38,7 @@ const StocksAndIndicesPage = () => (
<Layout>
<SEO
description={localize(
'Learn about the markets that you can trade online with Deriv, including forex, commodities, synthetic indices, and stock indices.',
'Learn about the markets that you can trade online with Deriv, including forex, commodities, synthetic indices, and stocks & indices.',
)}
title={localize('Markets | Markets to trade | Deriv')}
/>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/trade-types/margin/_available-markets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ const AvailableMarkets = () => {
/>

<StyledText weight="bold">
{localize('Stock indices')}
{localize('Stocks & indices')}
</StyledText>
</MobileCardHeader>
<Text>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/trade-types/options/_how-options-works.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ const HowOptionsWorks = () => {
<SideTab.Panel
label={<Localize translate_text="1. Market" />}
description={
<Localize translate_text="Choose from the four markets offered on Deriv – forex, stock indices, commodities, synthetic indices." />
<Localize translate_text="Choose from the four markets offered on Deriv – forex, stocks & indices, commodities, synthetic indices." />
}
>
<QueryImage data={data['option_market']} alt="Trade types option market" />
Expand Down
4 changes: 2 additions & 2 deletions src/pages/trade-types/options/_markets-available.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,12 @@ const MarketsAvailable = () => {
/>

<StyledText weight="bold">
{localize('Stock indices')}
{localize('Stocks & indices')}
</StyledText>
</MobileCardHeader>
<Text>
{localize(
'Trade digital options on stock indices and profit from the price movements in our competitively priced asset baskets.',
'Trade digital options on stocks & indices and profit from the price movements in our competitively priced asset baskets.',
)}
</Text>
<LearnMore
Expand Down