Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

NikitaK/ Convert help centre to ts 52484 #2404

Merged
35 commits merged into from Mar 4, 2022
Merged

NikitaK/ Convert help centre to ts 52484 #2404

35 commits merged into from Mar 4, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 29, 2021

Changes:

  • Help centre Page to TS

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Dec 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-com/FwBsJ69u5nzDHZjiQqsuoV7eaYwG
✅ Preview: https://deriv-com-git-fork-nikitak-deriv-help-centre-ts.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 49
🟢 Accessibility 92
🟢 Best practices 93
🟠 SEO 77
🟠 PWA 75

Lighthouse ran on https://deriv-com-git-fork-nikitak-deriv-help-centre-ts.binary.sx/

@ghost ghost marked this pull request as ready for review December 29, 2021 13:31
@ghost ghost requested review from njazuli-deriv and prince-deriv as code owners December 29, 2021 13:31
@ghost ghost self-requested a review December 29, 2021 13:31
@ghost ghost requested review from suthesank and yashim-deriv as code owners December 29, 2021 13:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.5% 3.5% Duplication

ghost
ghost previously approved these changes Feb 28, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.1% 5.1% Duplication

@ghost ghost merged commit 6afeaa9 into binary-com:master Mar 4, 2022
pavel-latyshou-deriv pushed a commit to pavel-latyshou-deriv/deriv-com that referenced this pull request Apr 8, 2022
* refactoring help-centre page in typescript

* in a way to end

* need check all_categories

* some changes cant run app

* some changes cant run app

* some changes cant run app

* some changes cant run app

* refactoring help-centre in typescript without answering components

* made types more cleaner. deleted custom file because this realized in latest master

* replaced interface on type

* fix code smell. return utility to non-type file

* return utility back to .js

* resolved some mistakes

* fix that app didnt run

* try to fix cognitive complexity

* try to fix cognitive complexity issue

* refactoring code with new component. try to solve cognitive complexity

* resolving issue about hard reading types

* refactoring class component to function

* refactoring class component to function

* continue refactoring

* refactoring from class component to functional. move from js to tsx

* delete useless file

* change naming by comments

* fix that derivx didnt show. type utility
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants