Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

farrah/fix navbar language switcher re-render #2488

Merged
6 commits merged into from
Mar 4, 2022
Merged

farrah/fix navbar language switcher re-render #2488

6 commits merged into from
Mar 4, 2022

Conversation

farrah-deriv
Copy link
Contributor

Changes:

  • Fixed navbar language switcher re-render

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Jan 11, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-com/6xnCdYHkdaxMmyEih5UHKjvB41yp
✅ Preview: https://deriv-com-git-fork-farrah-deriv-navbar-language-switcher.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 57
🟢 Accessibility 92
🟢 Best practices 93
🟠 SEO 77
🟠 PWA 75

Lighthouse ran on https://deriv-com-git-fork-farrah-deriv-navbar-language-switcher.binary.sx/

@farrah-deriv farrah-deriv marked this pull request as ready for review January 11, 2022 06:48
@farrah-deriv farrah-deriv requested a review from a user January 11, 2022 06:48
yashim-deriv
yashim-deriv reviewed Jan 11, 2022
View reviewed changes
@ghost
Copy link

ghost commented Jan 25, 2022

I'm getting a white screen on the test link 🙏

@ghost ghost requested a review from yashim-deriv January 27, 2022 02:29
habib-deriv
habib-deriv reviewed Feb 2, 2022
View reviewed changes
habib-deriv
habib-deriv previously approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@habib-deriv habib-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suthesank
Copy link
Contributor

Please help to resolve the conflicts @farrah-deriv 🙏

@suthesank suthesank closed this Feb 22, 2022
@suthesank suthesank reopened this Feb 22, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.6% 5.6% Duplication

yashim-deriv
yashim-deriv approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@yashim-deriv yashim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 797fd5c into binary-com:master Mar 4, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yashim-deriv yashim-deriv yashim-deriv approved these changes

@habib-deriv habib-deriv habib-deriv approved these changes

@njazuli-deriv njazuli-deriv Awaiting requested review from njazuli-deriv

@prince-deriv prince-deriv Awaiting requested review from prince-deriv prince-deriv is a code owner

@suthesank suthesank Awaiting requested review from suthesank

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@farrah-deriv @suthesank @yashim-deriv @habib-deriv