Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Al-amin/handle_website_status_cookie_on_VPN_change #2593

Merged
8 commits merged into from
Mar 10, 2022
Merged

Al-amin/handle_website_status_cookie_on_VPN_change #2593

8 commits merged into from
Mar 10, 2022

Conversation

alamin-deriv
Copy link
Contributor

Changes:

  • ...

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Jan 30, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-com/GpLmqEyS9ceR6xQqxM586GAhHZE9
✅ Preview: https://deriv-com-git-fork-alamin-deriv-handlewebsitestatuscooki-9e36e2.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 39
🟢 Accessibility 98
🟢 Best practices 93
🟢 SEO 92
🟠 PWA 75

Lighthouse ran on https://deriv-com-git-fork-alamin-deriv-handlewebsitestatuscooki-9e36e2.binary.sx/

@alamin-deriv alamin-deriv marked this pull request as ready for review January 30, 2022 08:55
@alamin-deriv alamin-deriv requested a review from a user January 30, 2022 08:55
@ghost
Copy link

ghost commented Feb 14, 2022

Could we just change the cookie duration to none? @alamin-deriv @prince-deriv

@alamin-deriv
Copy link
Contributor Author

@sean-binary how and if we're able to do that we don't need these changes?

@ghost
Copy link

ghost commented Feb 14, 2022

That's right. There's a COOKIE_EXPIRY_DAYS inside useWebsiteStatus hook.

@alamin-deriv
Copy link
Contributor Author

That's right. There's a COOKIE_EXPIRY_DAYS inside useWebsiteStatus hook.

Okay sure, let me look into it

ghost
ghost previously approved these changes Feb 28, 2022
View reviewed changes
alamin-deriv added 3 commits March 2, 2022 09:22
@alamin-deriv alamin-deriv requested a review from a user March 2, 2022 08:42
ghost
ghost previously approved these changes Mar 3, 2022
View reviewed changes
@alamin-deriv alamin-deriv requested a review from a user March 7, 2022 17:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

@ghost ghost merged commit 0dcbcf2 into binary-com:master Mar 10, 2022
pavel-latyshou-deriv pushed a commit to pavel-latyshou-deriv/deriv-com that referenced this pull request Apr 8, 2022
@alamin-deriv
Al-amin/handle_website_status_cookie_on_VPN_change (binary-com#2593)
8afc542 
* handle_website_status_cookie_on_VPN_change

* revert changes

* revert back my old changes

* revert back my old changes

* merged master
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@njazuli-deriv njazuli-deriv Awaiting requested review from njazuli-deriv

@prince-deriv prince-deriv Awaiting requested review from prince-deriv prince-deriv is a code owner

@suthesank suthesank Awaiting requested review from suthesank

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alamin-deriv