Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Niloofar Sadeghi / Fix broken terms and condition link for "zh-tw" and "zh-cn" language #2657

Merged
6 commits merged into from
Feb 23, 2022
Merged

Niloofar Sadeghi / Fix broken terms and condition link for "zh-tw" and "zh-cn" language #2657

6 commits merged into from
Feb 23, 2022

Conversation

niloofar-deriv
Copy link
Contributor

@niloofar-deriv niloofar-deriv commented Feb 16, 2022 •
edited
Loading

Changes:

  • ...

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@niloofar-deriv niloofar-deriv requested a review from a user February 16, 2022 12:02
@vercel
Copy link

vercel bot commented Feb 16, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-com/4vWQTrZ1181Nnq5Ef4aji4cWhgnX
✅ Preview: https://deriv-com-git-fork-niloo-fs-chinees-url-bug.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 43
🟢 Accessibility 92
🟢 Best practices 93
🟠 SEO 77
🟠 PWA 75

Lighthouse ran on https://deriv-com-git-fork-niloo-fs-chinees-url-bug.binary.sx/

@github-actions
Copy link
Contributor

Running Lighthouse audit...

habib-deriv
habib-deriv previously approved these changes Feb 16, 2022
View reviewed changes
@ghost
Copy link

ghost commented Feb 21, 2022

Sorry about this but there was some refactor on the code pushed to master that caused conflicts. Could you please pull the latest master and help to resolve the conflicts?

ghost
ghost reviewed Feb 21, 2022
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ghost ghost merged commit 82baa86 into binary-com:master Feb 23, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@habib-deriv habib-deriv habib-deriv left review comments

@suthesank suthesank Awaiting requested review from suthesank

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@njazuli-deriv njazuli-deriv Awaiting requested review from njazuli-deriv

@prince-deriv prince-deriv Awaiting requested review from prince-deriv prince-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niloofar-deriv @habib-deriv