Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

suthesh/refactor-footer #2668

Merged
3 commits merged into from
Feb 23, 2022
Merged

Conversation

suthesank
Copy link
Contributor

@suthesank suthesank commented Feb 21, 2022

Changes:

  • use new show component
  • remove unused codes

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Feb 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-com/3gy4NRXULA7ZbFt726wrWRcaLE1Q
✅ Preview: https://deriv-com-git-fork-suthesan-deriv-suthesh-refactor-footer.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 46
🟢 Accessibility 92
🟢 Best practices 93
🟠 SEO 77
🟠 PWA 75

Lighthouse ran on https://deriv-com-git-fork-suthesan-deriv-suthesh-refactor-footer.binary.sx/

yashim-deriv
yashim-deriv previously approved these changes Feb 22, 2022
Copy link
Contributor

@yashim-deriv yashim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.4% 3.4% Duplication

@ghost ghost merged commit c1f67fc into binary-com:master Feb 23, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants