Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Fix failed build due to packagelock dependency #2678

Merged
1 commit merged into from Feb 23, 2022
Merged

Fix failed build due to packagelock dependency #2678

1 commit merged into from Feb 23, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 23, 2022 •
edited by ghost
Loading

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Feb 23, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-com/9GgRKa7ZSj5dtF2vkrUsDqnYErh9
✅ Preview: https://deriv-com-git-fork-sean-binary-fix-build.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 43
🟢 Accessibility 92
🟢 Best practices 93
🟠 SEO 77
🟠 PWA 75

Lighthouse ran on https://deriv-com-git-fork-sean-binary-fix-build.binary.sx/

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.1% 4.1% Duplication

@ghost ghost marked this pull request as ready for review February 23, 2022 08:18
@ghost ghost requested review from yashim-deriv and prince-deriv as code owners February 23, 2022 08:18
njazuli-deriv
njazuli-deriv approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@njazuli-deriv njazuli-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 52916ee into binary-com:master Feb 23, 2022
@ghost ghost deleted the fix-build branch February 23, 2022 08:19
ghost pushed a commit that referenced this pull request Feb 23, 2022
@seanho96
Revert assets info (#2679)
a678e35 
* Revert "chore: update minor versions + fix failed build due to packagelock dependency (#2678)"

This reverts commit 52916ee.

* reverts 52916ee 7f5ab36

Co-authored-by: Sean Ho <[email protected]>
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv

@prince-deriv prince-deriv Awaiting requested review from prince-deriv prince-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njazuli-deriv @seanho96