Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Urlhandling from derivgo #2696

Merged
13 commits merged into from
Mar 10, 2022
Merged

Urlhandling from derivgo #2696

13 commits merged into from
Mar 10, 2022

Conversation

ashraf-deriv
Copy link
Contributor

@ashraf-deriv ashraf-deriv commented Mar 1, 2022 •
edited
Loading

Changes:

  • ...

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@ashraf-deriv ashraf-deriv requested a review from a user March 1, 2022 02:55
@vercel
Copy link

vercel bot commented Mar 1, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-com/jQo3PLeLPJCayD4G7uSaeC1aLfHE
✅ Preview: https://deriv-com-git-fork-ashraf-deriv-urlhandling-from-derivgo.binary.sx

suthesank
suthesank reviewed Mar 1, 2022
View reviewed changes
ghost
ghost reviewed Mar 1, 2022
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 30
🟢 Accessibility 98
🟢 Best practices 93
🟢 SEO 92
🟠 PWA 50

Lighthouse ran on https://deriv-com-git-fork-ashraf-deriv-urlhandling-from-derivgo.binary.sx/

ghost
ghost reviewed Mar 1, 2022
View reviewed changes
ghost
ghost reviewed Mar 4, 2022
View reviewed changes
ghost
ghost reviewed Mar 4, 2022
View reviewed changes
@ghost
Copy link

ghost commented Mar 4, 2022

Also please help to resolve the conflicts by pulling the upstream. git pull upstream master

@ashraf-deriv ashraf-deriv reopened this Mar 4, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
6.4% 6.4% Duplication

ghost
ghost approved these changes Mar 4, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghost ghost merged commit 3939ac2 into binary-com:master Mar 10, 2022
pavel-latyshou-deriv pushed a commit to pavel-latyshou-deriv/deriv-com that referenced this pull request Apr 8, 2022
@ashraf-deriv @ashrafali-v
Urlhandling from derivgo (binary-com#2696)
529f7d7 
* replaced financial disclosure report pdf with new one

* handle urls frpm derivgo app

* changes based on code review

* variable name formating

* add common function in to utility

* improvement

* empty commit to trigger build step

* issue fix

* updates based on fe review

Co-authored-by: ashrafali-v <[email protected]>
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@suthesank suthesank suthesank left review comments

@njazuli-deriv njazuli-deriv Awaiting requested review from njazuli-deriv

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@prince-deriv prince-deriv Awaiting requested review from prince-deriv prince-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashraf-deriv @suthesank @ashrafali-v