Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

MohammadH/Endpoint localstorage #2755

Merged
9 commits merged into from
Mar 11, 2022
Merged

MohammadH/Endpoint localstorage #2755

9 commits merged into from
Mar 11, 2022

Conversation

mohammad-hashemi-deriv
Copy link
Contributor

Changes:

  • Add manual clients country to localstorage to prevent overwriting clients country by ip

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Mar 10, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-com/6669KJAxjY8ozzLGGJrh79ZFRPcR
✅ Preview: https://deriv-com-git-fork-mohammad-rework-endpoint-localstorage.binary.sx

@mohammad-hashemi-deriv mohammad-hashemi-deriv marked this pull request as ready for review March 10, 2022 15:36
@mohammad-hashemi-deriv mohammad-hashemi-deriv requested a review from a user March 10, 2022 15:36
@mohammad-hashemi-deriv mohammad-hashemi-deriv changed the title Endpoint localstorage MohammadH/Endpoint localstorage Mar 10, 2022
prince-deriv
prince-deriv previously approved these changes Mar 10, 2022
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 30
🟢 Accessibility 98
🟢 Best practices 93
🟢 SEO 92
🟠 PWA 50

Lighthouse ran on https://deriv-com-git-fork-mohammad-rework-endpoint-localstorage.binary.sx/

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
9.0% 9.0% Duplication

@ghost ghost merged commit fe30c9b into binary-com:master Mar 11, 2022
pavel-latyshou-deriv pushed a commit to pavel-latyshou-deriv/deriv-com that referenced this pull request Apr 8, 2022
@mohammad-hashemi-deriv
MohammadH/Endpoint localstorage (binary-com#2755)
760762d 
* update package-lock.json

* update package lock

* fix: add manual clients country to localstorage to prevent overwriting clients country by ip

* fix: remove local storage manual country when press on reset button

* fix: add isbrowser before using localstorage
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prince-deriv prince-deriv prince-deriv left review comments

@njazuli-deriv njazuli-deriv Awaiting requested review from njazuli-deriv

@suthesank suthesank Awaiting requested review from suthesank

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohammad-hashemi-deriv @prince-deriv