-
Notifications
You must be signed in to change notification settings - Fork 183
yashim/perf: specify higher compression for certain images. force avif as main format #4216
yashim/perf: specify higher compression for certain images. force avif as main format #4216
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Running Lighthouse audit... |
β¦mage_compression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eee65dc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yashim-deriv π
I found some UI bug with position with your approach and decided to help you a little bit because it's always annoying to work with positions.
How it looked:
How it looks with my fix:
How it's actually looks in deriv.com π
:
Please take this fix if you're agree π
https://github.com/binary-com/deriv-com/pull/4245/files#diff-8a30e24d8f3b51c96b9625adbc55ae22478b0e017a11ee0ae555eb0ee9a583bfR74-R84
β¦mage_compression
Kudos, SonarCloud Quality Gate passed!Β Β
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Konstantinos / The words βnot availableβ in the payment methods section is misleading, this needs to be revised (#4188) * fix: fix not available * Apply suggestions from code review Updated content from Not Applicable to Not applicable --------- Co-authored-by: Konstantinos-Gk <[email protected]> Co-authored-by: Habib Deriv <[email protected]> * Yaswanth/87208/pnl margin bugfix (#4154) * refactor: adding hard lazy loading in cfd page * refactor: adding hard lazy loading in cfd page * refactor: adding hard lazy loading in cfd page * refactor: adding hard lazy loading in cfd page * refactor: plp margin calculator bug fix * refactor: plp margin calculator bug fix * Yaswanth/88385/pnl calculator console warning fix (#4173) * refactor: adding hard lazy loading in cfd page * refactor: adding hard lazy loading in cfd page * refactor: adding hard lazy loading in cfd page * refactor: adding hard lazy loading in cfd page * refactor: plp margin calculator bug fix * refactor: plp margin calculator bug fix * refactor: hard lazy load in dmt5 page * refactor: hard lazy loader in dmt5 page * refactor: to fix console warning for pnl margin * Translation [FE Deriv.com squad] 85828 NikitK / Derived FX, add Vol 20 (#4067) * feat: update derived_dx data * fix: path of image * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * feat: update description text of derived-fx * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch --------- Co-authored-by: DerivFE <[email protected]> * Revert "Yaswanth/87208/pnl margin bugfix (#4154)" (#4190) This reverts commit 4a3edd2. * refactor: to fix pnl margin calculator issue (#4191) * chore: update translation strings (#4195) * Revert "Yaswanth/88385/pnl calculator console warning fix (#4173)" (#4199) This reverts commit 6ffe151. * refactor: to fix pnl margin calculator issues (#4208) * Konstantinos / [FE Deriv.com squad] Content changes need to be done on Locations pages. (#4203) * fix: locations changes * fix: job location name --------- Co-authored-by: Konstantinos-Gk <[email protected]> * chore: update translation (#4212) * fix: available tabs toggler (#4214) * fix: update tnc pdf (#4160) Co-authored-by: meenakshi-deriv <[email protected]> * refactor: cleanup after academy movement (#4225) * Fix IP cookie issue loop for login (#4204) * chore: fix ip cookie issue * chore: fix ip cookie issue * chore: made country readonly * Mitra/update uk office location (#4215) * fix: π update uk office location * fix: π change the map link * fix: π add comma and change quality of image * Translation strings (#4235) * chore: translation strings * chore: update code * Konstantinos / [EU] Footer content is displayed twice for EU clients (#4210) * fix: remove duplicate message * fix: remove message for cpa too --------- Co-authored-by: Konstantinos-Gk <[email protected]> * perf: update payment method sorting for EU (#4223) Co-authored-by: Muhammad Fasih <[email protected]> * [FE Deriv.com squad] Translation NikitK/ Add IB commissions for 2 new volatility indices (#4148) * feat: update affiliate ib information * auto-pull-translation * 89196 NikitK/The first letter of the word Synthetics and the last letter of the word Derived FX are cut in responsive (#4224) * fix: make TabList on market page responsive * fix: make TabList on market page responsive * yashim/speed up country checks (#4221) * fix: speed up country checks * fix: add null check * fix: more null checks * fix: cleanup * fix: use previous logic * fix: add suggestions from code review * refactor: move some declarations into useeffect * feat: added fallback * fix: update website_status state * yashim/perf: specify higher compression for certain images. force avif as main format (#4216) * feat: compress specific images * feat: modified some images * fix: image positioning * chore: modified settings * fix: removed placeholder * feat: adjusted quality based on qa * chore: further bumped quality * chore: more compression * fix: revert animation reduction * fix: error in ios * fix: remove border * fix: container height * fix: image positioning * fix: remove placeholder * yashim/fix: re-added eu redirection with updated logic (#4253) * fix: re-added eu redirection with updated logic * chore: change import oder * yashim/fix: client country redirect check (#4258) * chore: fix staging redirect (#4256) * Habib/fix redirect subdomain (#4259) * chore: fix staging redirect * chore: add fix * Revert "yashim/fix: client country redirect check (#4258)" (#4261) This reverts commit 4103e44. * Revert "yashim/fix: re-added eu redirection with updated logic (#4253)" (#4264) This reverts commit 04d1faa. * Revert "yashim/speed up country checks (#4221)" (#4251) This reverts commit 52a03a7. * fix: π hide livechat and whatsapp in help centre questions (#4273) * fix: fixed padding issue (#4247) Co-authored-by: meenu-deriv <[email protected]> * Farhan Ahmad Nurzi/Bug_-_Help_center_watermark_-_>_βtradeβ_is_not_translated_for_FR,ID,IT_&_DE (#4254) * auto-pull-translation * auto-pull-translation * translation: fetch latest translations * auto-pull-translation * translation: fetch latest translations * refactor: update plugin (#4267) * chore: bring gcm user id (#4276) * fix: updated translation key extraction (#4277) - preventing old approach to include new approach in extracted keys * mitra/fix: π₯ remove redirection from client side (#4226) * fix: π rely on eu domain to show eu content (#4302) * Revert "fix: π rely on eu domain to show eu content (#4302)" (#4304) This reverts commit e620d2f. * Revert "mitra/fix: π₯ remove redirection from client side (#4226)" (#4305) This reverts commit 7f2b298. * Konstantinos / [FE Deriv.com squad] Update footer for deriv.com and eu.deriv.com (#4172) * fix: fix disclaimer * auto-pull-translation * translation: π sync translations from crowdin feature branch * fix: subtasks except previous-page-button-issue * fix: fix links * fix: fix redirection issue * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * fix: subtasks * fix: remove no bw var * fix: pdf wrong on lanuage change * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * fix: underline hover * auto-pull-translation * translation: π sync translations from crowdin feature branch * fix: compliance * fix: remove eu stat * fix: add full stop * auto-pull-translation * translation: π sync translations from crowdin feature branch --------- Co-authored-by: Konstantinos-Gk <[email protected]> Co-authored-by: DerivFE <[email protected]> * Mitra/Pr 88609 remove create demo account when client come from deriv go (#4244) * fix: π remove parts not needed when coming from deriv go * fix: π remove parts not needed when coming from deriv go * style: βοΈ add empty line * fix: π small fix * fix: π fix syntax issue * fix: π fix vercel deployment on ssr * fix: π fix vercel error * fix: π fix vercel deployment * empty: π to redeploy and trigger build * fix: π₯ fix css issue for nav * fix: π fix delay on hiding the nav * fix: π apply changes only to cryptocurrency and synthetic page * fix: π fix vercel failur * fix: π fix for the rendering issue * fix: π fix css issues * fix: π₯ hide other markets section * fix: βͺ revert logic changes * fix: π¨ resolve comments * fix: added log to check on run time * fix: π fix flickering * fix: π fix flickering * fix: π fix flickering * fix: π fix flickering * fix: π fix flickering * fix: π fix flickering * fix: π fix flickering * fix: π fix flickering * fix: π hide button * fix: π hide tabs * fix: π¬ fetch master translation (#4307) * Mitra/Remove redirection for eu and row from client side (#4309) * fix: π rely on eu domain to show eu content * fix: π₯ remove redirection from client side * chore: remove popup (#4320) * chore: add logic (#4322) * auto-pull-translation * Farhan Ahmad Nurzi / When logged in client goes to deriv.com page there is a glitch in the CTA button Get trading (#4299) * fix: glitch in cta button get trading * refactor: change state setter function name * refactor: move the auth check setter function before setInterval function * fix searching help center (#4283) * fix searching * renaming * fix translations placeholder --------- Co-authored-by: Eduard Hrachou <[email protected]> * MohammadH/ Scroll to indices by query param and id (#4241) * feat: scroll to the id indices * fix: id attribute works for all instruments now * chore: increase ammount of offset to give more space from the top * feat: add query param for market tabs * fix: typos in id names * fix: query param links redirect to homepage in non-english languages * fix: derived-fx id scroll * fix: disable scroll on tab change * fix: generates page on query param * fix: scroll into item by dom methods * fix: avoid error if element id is not in the dom * fix: double scrolling by decreasing gatsby scroll duration to 0 * fix: increase scroll offset to 170 in useeffect * fix: decrease scroll time to 500ms * chore: increase timeout to 800ms * chore: increase timeout to 1000ms * Farhan Ahmad Nurzi / Header is floating for all the markets page in deriv.com (#4310) * fix: header background transparent bug in markets pages * refactor: delete unused useState in utility.ts * refactor: delete an useEffect * refactor: delete comment Co-authored-by: Farzin Mirzaie <[email protected]> --------- Co-authored-by: Farzin Mirzaie <[email protected]> * Konstantinos / Adding MT5 Appstore link in deriv.com (#4301) * feat: add dmt5 link * feat: add dmt5 links --------- Co-authored-by: Konstantinos-Gk <[email protected]> * Konstantinos / [FE Deriv.com squad] Content changes to regulatory information page (#4257) * fix: sentence * fix: sentence2 * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * translation: π sync translations from crowdin feature branch --------- Co-authored-by: Konstantinos-Gk <[email protected]> Co-authored-by: DerivFE <[email protected]> * Konstantinos / [FE Deriv.com squad] Add 2 new symbols Volatility indices under Derived/synthetics on the website for ROW & EU (#4037) * chore: added new volatility * auto-pull-translation * auto-pull-translation * chore: add symbols to row multiplers tab * fix: fix descriptions and visibility * fix: update descriptions,symbols and design * chore: fix design issues * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * chore: package update * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * fix: padding and space * auto-pull-translation * translation: π sync translations from crowdin feature branch * chore: fix translation * chore: translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * chore: fix spacing * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * fix: remove indices for row multipliers tab * auto-pull-translation * translation: π sync translations from crowdin feature branch * fix: duplicate line * fix: gap * auto-pull-translation * fix: space after number * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * fix: bug and list issues * fix: bug breaking page * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * chore: remove space after 1 * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * fix: height * fix: height2 * fix: height 3 * auto-pull-translation * translation: π sync translations from crowdin feature branch --------- Co-authored-by: Konstantinos-Gk <[email protected]> Co-authored-by: DerivFE <[email protected]> * Farhan Ahmad Nurzi / Slow loading Payment Method page while user is on VPN (#4324) * fix: payment methods glitch during page refresh * fix: hide expanded payment methodslist upon rendering * fix: accordion flickering for eu payment methhods * refactor: update payment method * refactor: update payment_method_data for non_eu in useeffect * refactor: delete default is_eu * refactor: initialize is_eu to true to prevent accordions flickering * refactor: refactor useeffect for filtering and mapping payment methods * refactor: add loader in payment-methods accordion section * refactor: delete is_eu default value * fix: hide reference row if there is no reference in payment method mobile view (#4311) * fix: replace pdf (#4316) Co-authored-by: Konstantinos-Gk <[email protected]> * Konstantinos / Jeton EU (#4319) * fix: jeton add * fix: minor issues * fix: padding --------- Co-authored-by: Konstantinos-Gk <[email protected]> * Fasih/:Pr 90177 unable to redirect back to previous question (#4293) * feat: optimised tabs with fixing back button * fix: removed optimisations and removed new button * fix: added check because build is getting failed * docs: added discription in tab state hook --------- Co-authored-by: Muhammad Fasih <[email protected]> * fix: dfx supplementary terms file (#4342) * fix: changing website content from url param (#4297) * fix: changing website content from url param * fix: condition for browser * Konstantinos regul update 2 (#4353) * fix: sentence * fix: sentence2 * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * translation: π sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: π sync translations from crowdin feature branch --------- Co-authored-by: Konstantinos-Gk <[email protected]> Co-authored-by: DerivFE <[email protected]> * Konstantinos / [FE Deriv.com squad] Change of role name from Chief Compliance Officer to Chief Risk & Compliance Officer in Deriv (About Us) page (#4291) * fix: joanna role change * auto-pull-translation * translation: π sync translations from crowdin feature branch --------- Co-authored-by: Konstantinos-Gk <[email protected]> Co-authored-by: DerivFE <[email protected]> * Fetch translation crowdin (#4352) * text: π¬ fix translation issue on staging * translations: update translation files * text: π¬ fetch master translation * fix: vercel2 * fix: vercel * fix: vercel * fix: vercel --------- Co-authored-by: Konstantinos-Gk <[email protected]> Co-authored-by: Habib Deriv <[email protected]> Co-authored-by: yaswanth-deriv <[email protected]> Co-authored-by: NikitK-deriv <[email protected]> Co-authored-by: DerivFE <[email protected]> Co-authored-by: meenakshi-deriv <[email protected]> Co-authored-by: meenakshi-deriv <[email protected]> Co-authored-by: mitra-deriv <[email protected]> Co-authored-by: fasihali-deriv <[email protected]> Co-authored-by: Muhammad Fasih <[email protected]> Co-authored-by: Yashim Wong <[email protected]> Co-authored-by: Farhan Ahmad Nurzi <[email protected]> Co-authored-by: ashraf-deriv <[email protected]> Co-authored-by: Michio <[email protected]> Co-authored-by: Eduard Hrachou <[email protected]> Co-authored-by: Eduard Hrachou <[email protected]> Co-authored-by: mohammad-hashemi-deriv <[email protected]> Co-authored-by: Farzin Mirzaie <[email protected]> Co-authored-by: Nuzhy-Deriv <[email protected]>
Changes:
Type of change