Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Dark mode #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Dark mode #175

wants to merge 8 commits into from

Conversation

irgolic
Copy link
Member

@irgolic irgolic commented Feb 19, 2021

Fixes #67

@irgolic irgolic mentioned this pull request Feb 19, 2021
Draft
3 tasks
@markotoplak markotoplak mentioned this pull request Apr 26, 2021
Closed
3 tasks
markotoplak
markotoplak reviewed Mar 6, 2023
View reviewed changes
orangecanvas/canvas/items/graphicstextitem.py
@@ -113,10 +110,13 @@ def __updateDefaultTextColor(self):
# type: () -> None
if self.__styleState & QStyle.State_Selected \
and not self.__styleState & QStyle.State_Editing:
role = QPalette.HighlightedText
bgRole = QPalette.Light
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This modification was written before #177. Perhaps we should instead leave role = QPalette.HighlightedText from #177 in.

@markotoplak
Copy link
Member

markotoplak commented Mar 6, 2023 •
edited
Loading

I rebased this just enough so I could try this with biolab/orange3#5287. There are some remaining errors, but it runs kinda runs.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023 •
edited
Loading

Codecov Report

Patch coverage: 85.50% and project coverage change: +0.04 🎉

Comparison is base (26b1446) 74.73% compared to head (75e3295) 74.78%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   74.73%   74.78%   +0.04%     
==========================================
  Files          96       97       +1     
  Lines       20621    20770     +149     
==========================================
+ Hits        15411    15532     +121     
- Misses       5210     5238      +28
Impacted Files Coverage Δ
orangecanvas/document/quickmenu.py 68.40% <52.63%> (-0.34%) ⬇️
orangecanvas/registry/qt.py 74.25% <62.50%> (-0.87%) ⬇️
orangecanvas/gui/palette_utils.py 67.64% <67.64%> (ø)
orangecanvas/gui/toolbox.py 91.58% <80.00%> (+0.56%) ⬆️
orangecanvas/gui/utils.py 66.06% <81.08%> (+1.17%) ⬆️
orangecanvas/canvas/items/linkitem.py 85.34% <83.33%> (-0.40%) ⬇️
orangecanvas/scheme/readwrite.py 73.21% <92.85%> (+1.24%) ⬆️
orangecanvas/canvas/items/nodeitem.py 86.66% <95.87%> (+0.35%) ⬆️
orangecanvas/application/widgettoolbox.py 57.26% <100.00%> (-4.19%) ⬇️
orangecanvas/canvas/items/__init__.py 100.00% <100.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markotoplak markotoplak markotoplak left review comments

Assignees

@PrimozGodec PrimozGodec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dark mode
4 participants
@irgolic @markotoplak @codecov-commenter @PrimozGodec