Issue 4940 - Loosen restriction of FormattedSeq._table in Restriction module#4941
Issue 4940 - Loosen restriction of FormattedSeq._table in Restriction module#4941peterjc merged 3 commits intobiopython:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4941 +/- ##
==========================================
+ Coverage 85.37% 86.26% +0.89%
==========================================
Files 282 282
Lines 59405 59405
==========================================
+ Hits 50716 51247 +531
+ Misses 8689 8158 -531 ☔ View full report in Codecov by Sentry. |
|
Thanks @peterjc I made that change |
peterjc
left a comment
There was a problem hiding this comment.
Sorry, I didn't look closely enough at the test earlier, but this is an easy fix:
======================================================================
FAIL: test_non_iupac_letters (test_Restriction.SequenceTesting)
Test if non-IUPAC letters raise a TypeError.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/biopython/biopython/Tests/test_Restriction.py", line 57, in test_non_iupac_letters
with self.assertRaises(TypeError):
AssertionError: TypeError not raised
----------------------------------------------------------------------
Either remove that test, or modify it to test random non-letter symbols raise the error?
|
Hey @peterjc should be fixed now. Sorry about overlooking it, when I run this locally other tests failed and none seemed related to Restriction. Sorry about that. It's good to test with the |
I hereby agree to dual licence this and any previous contributions under both
the Biopython License Agreement AND the BSD 3-Clause License.
I have read the
CONTRIBUTING.rstfile, have runpre-commitlocally, and understand that continuous integration checks will be used to
confirm the Biopython unit tests and style checks pass with these changes.
Closes #4940