Trivial: Fix typos in various files #8541
Conversation
src/wallet/wallet.cpp
Outdated
There was a problem hiding this comment.
I think translators already take care of localisation (or localization).
There was a problem hiding this comment.
My goal was to have a standard spelling internally, for things that would never be shown to the user (such as comments as well as localization strings)
There was a problem hiding this comment.
Ah, I just realized that discounting files in qt/locale was not a good idea
$ grep -r "Prune: last wallet synchronisation goes beyond pruned data." . | wc -l
23
$
There was a problem hiding this comment.
I'll revert the synchronisation vs synchnonization one.
|
I disagree these are typos. The spelling is correct. |
|
They go against the standard spelling defined elsewhere. They might not be typos, true, because there are multiple accepted spellings, but they are definitely outliers compared to the rest of the codebase. I show this in the pull request description. |
|
@leijurv I am not aware we demand one spelling over the other. It shouldn't matter for either comments or translation strings since they are handled by translators. |
|
Keep in mind most developers are international and do not speak English as their native tongue. It probably will turn out difficult to enforce spelling. If you feel strong about typos, there would be another one: |
|
Okay. Why was #8505 accepted then? Was that an error or something? |
|
The other pull fixed some actual typos On Thu, Aug 18, 2016 at 7:37 PM, Leijurv [email protected] wrote:
|
|
Would you accept a pull request to revert the non-typos fixed by #8505? Specifically the correction of outlying spellings of reorganis/ze, serialis/ze, and optimis/ze? |
|
IMO such pull requests are not productive... they may are if they fix many of typos in one PR. |
|
Agree with @jonasschnelli and @MarcoFalke , too much of this is not productive. These are just code comments, if they're hard to understand, then certainly fixing a few typos isn't going to make that better. Try to restrict fixing typos to end-user facing messages. |
It seems that "initializ-" is the standard, and not "initialis-"