Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix lighthouse geometry estimation example #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix lighthouse geometry estimation example #459

merged 1 commit into from
Jun 27, 2024

Conversation

gemenerik
Copy link
Member

@gemenerik gemenerik commented Jun 27, 2024 •
edited
Loading

  • Fixed the data collection reattempts. ensuring the loop runs again if necessary to successfully obtain recordings.
  • Refactored code by consolidating data recording processes into dedicated functions for improved organization and readability.
  • Implemented timeouts in the data recording functions to prevent indefinite blocking

@gemenerik
Fix lighthouse geometry estimation example
d6e5c0a 
* Fixed broken while loops that were incorrectly exiting immediately without retries.
* Gathered data recording code into functions.
Implemented timeout and retry mechanism in record_angles_average.
* Added timeouts for recording data
@gemenerik gemenerik force-pushed the rik/bs_geo_est_fix branch from b8b5f8a to d6e5c0a Compare June 27, 2024 09:10
ataffanel
ataffanel approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@ataffanel ataffanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gemenerik gemenerik merged commit ad3b4da into master Jun 27, 2024
@tobbeanton tobbeanton deleted the rik/bs_geo_est_fix branch June 28, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ataffanel ataffanel ataffanel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gemenerik @ataffanel