Ensure proper thread and link cleanup on failed Crazyflie connections / disconnects #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ataffanel
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures the radio link is properly closed when
reset_to_bootloadertimes out (e.g., Crazyflie is off), preventing accumulation of RadioDriverThread instances on repeated failures.Ensures IncomingPacketHandler threads are stopped and replaced when the link is closed, preserving callbacks for reconnects.
Ensures link is fully closed upon failed attempt to open link
Together, these changes address much of #554. Still, more underlying issues remain. Addressing them fully will require deeper refactoring rather than patch-level fixes.