Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kleetus
Copy link
Contributor

@kleetus kleetus commented Apr 4, 2016

closes #10

  • please pardon the formatting-only changes, there are so many ways that contributions come in. I decided to settle on "format how IntelliJ does it" versus trying to accommodate a million styles.
  • I also added my iml file for IntelliJ to help people get going if they use IntelliJ.
  • the additions from @jmswenski allow invoice operations without the crypto keys, should users want to use the public API.

Jason Swenski and others added 6 commits April 4, 2016 14:35
…l signing the requests and therefore not actually using the public API. This doesn't work in some cases because the /invoice endpoint doesn't support some facades.

Also refactors some of the parameter building to off-the-shelf apache commons methods
…lder

I'll contribute this in a later pull request
- As per mrosseel's pom file, conversion of all dependencies to use maven2. This will ease the pain of managing a bunch of jar files in lib
- Repaired some deprecation warnings in bitcoinj dependency around Sha256 creation and ECKey construction.
- Adjusted test harness to create tokens for pos/merchant facade, this is done once the first time someone runs the tests. The test runner just has to pair with their test account. The tester is does not have cascading test failures that might confuses as to what he/she needs to do.
- Added some notes about how to do the refund test.
- Added constructors for passing the URI of your private key. We prefer to have users of this library pass in a URI for their key file. That way, this api isn't just writing new key files to the current working directory. If the URI does not have a key already, one will be created there (if writeable). It will be the user's responsibility to safeguard their private keys.
- A bit of code cleanup in terms of spelling and removal of warnings, etc.
@jmswenski
Copy link

<3

@kleetus kleetus merged commit 00588dc into bitpay:master Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getInvoice Doesn't Use Public Facade

3 participants