This repository was archived by the owner on Feb 19, 2020. It is now read-only.
Add accessibility label to feedback list view cell#409
Merged
ElektrojungeAtWork merged 3 commits intoApr 28, 2017
Merged
Conversation
Huan9
reviewed
Apr 25, 2017
| "HockeyAuthenticationAuthSecretMissing" = "HockeySDK “authorization secret” が設定されていません。このAppのデベロッパに連絡してください。"; | ||
|
|
||
| /* Accessibility strings */ | ||
| "HockeyAccessibilityHintRequired" = "必須"; |
There was a problem hiding this comment.
"HockeyAccessibilityHintRequired" = "必填"; to be consistent with https://github.com/bitstadium/HockeySDK-iOS/pull/409/files#diff-2dad4c3109cff081ead9259c8d910397R279
Contributor
Author
There was a problem hiding this comment.
@Huan9 @TroubleMakerBen
Please, find translations for key 'HockeyAuthenticationViewControllerPasswordPlaceholder' for HZ and JP. Translations are different. Is it a mistake?
Contributor
|
Please use the following translations...in general we want "Fieldname (required)", e.g. The value for "FieldName" can be found in other parts of the localization files. |
Contributor
Author
|
Restart build |
8b7e580 to
03f7e1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found only one place where screen reader didn't read all information.