Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 19, 2020. It is now read-only.

Calling getResourceValue asynchronously#443

Merged
ElektrojungeAtWork merged 5 commits into
bitstadium:developfrom
bmourat:fix/get-resource-value-async
Aug 3, 2017
Merged

Calling getResourceValue asynchronously#443
ElektrojungeAtWork merged 5 commits into
bitstadium:developfrom
bmourat:fix/get-resource-value-async

Conversation

@bmourat

@bmourat bmourat commented Aug 1, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@msftclas

msftclas commented Aug 1, 2017

Copy link
Copy Markdown

@bmourat,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Comment thread Classes/BITHockeyHelper.m
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
NSError *getResourceError = nil;
NSNumber *appSupportDirExcludedValue;
if ([directoryURL getResourceValue:&appSupportDirExcludedValue forKey:NSURLIsExcludedFromBackupKey error:&getResourceError] && appSupportDirExcludedValue) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either log NSError or just pass nil

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please log the error using log level error.

Comment thread Classes/BITHockeyHelper.m Outdated
NSNumber *appSupportDirExcludedValue;
if ([directoryURL getResourceValue:&appSupportDirExcludedValue forKey:NSURLIsExcludedFromBackupKey error:&getResourceError] && appSupportDirExcludedValue) {
NSError *setResourceError = nil;
[directoryURL setResourceValue:@NO forKey:NSURLIsExcludedFromBackupKey error:&setResourceError];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@ElektrojungeAtWork ElektrojungeAtWork merged commit 377ecab into bitstadium:develop Aug 3, 2017
@bmourat bmourat deleted the fix/get-resource-value-async branch August 11, 2017 10:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants