Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 19, 2020. It is now read-only.

Make it possible to change current logging handler#516

Merged
ElektrojungeAtWork merged 1 commit into
bitstadium:developfrom
piotrwach:dev/expose-logging-header
Jun 19, 2018
Merged

Make it possible to change current logging handler#516
ElektrojungeAtWork merged 1 commit into
bitstadium:developfrom
piotrwach:dev/expose-logging-header

Conversation

@piotrwach

Copy link
Copy Markdown
Contributor

It should be possible to change logging handler used inside HockeySDK. For example application that I am working on uses its own logging system, and we want all logs to use it, including 3rd party libraries.

@msftclas

msftclas commented Apr 24, 2018

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@piotrwach

Copy link
Copy Markdown
Contributor Author

I don't know why one of the checks is failing, as I don't have permissions to view bitrise.

@ElektrojungeAtWork

Copy link
Copy Markdown
Contributor

Hi @piotrwach,
The HockeyLogger is not designed to be replaced by another logger. It's purpose is to allow for an API to adjust the amount of logs that the SDK emmits.
Maybe I'm missing something in your PR, but how does making our header file public solve your issue?

@piotrwach

Copy link
Copy Markdown
Contributor Author

@TroubleMakerBen our app requires all logs to be stored encrypted on the device. By making BITHockeyLogger.h header public, we can change currentLogHandler to use our internal logging system.

@ElektrojungeAtWork ElektrojungeAtWork merged commit 1dd0eff into bitstadium:develop Jun 19, 2018
@ElektrojungeAtWork

Copy link
Copy Markdown
Contributor

Thx for the explanation @piotrwach.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants