Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Eeebru
Copy link
Contributor

@Eeebru Eeebru commented Sep 18, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SRE-3019

📔 Objective

  • Implement a send email retry feature for Azure Queue Mail in Admin Hosted services.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Eeebru Eeebru self-assigned this Sep 18, 2025
@Eeebru Eeebru marked this pull request as draft September 18, 2025 16:02
Copy link

Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.04%. Comparing base (d83395a) to head (7f4d696).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...dmin/HostedServices/AzureQueueMailHostedService.cs 0.00% 39 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6351      +/-   ##
==========================================
- Coverage   54.28%   50.04%   -4.24%     
==========================================
  Files        1831     1832       +1     
  Lines       81483    81565      +82     
  Branches     7217     7224       +7     
==========================================
- Hits        44230    40823    -3407     
- Misses      35601    39172    +3571     
+ Partials     1652     1570      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details88e42911-2631-43ae-9928-ca33fbfa8646

Great job! No new security vulnerabilities introduced in this pull request

@Eeebru Eeebru changed the title implement the Azure mail queue retry feature implement a retry feature the Azure mail queue in Admin Sep 19, 2025
@Eeebru Eeebru changed the title implement a retry feature the Azure mail queue in Admin implement a retry feature for Azure mail queue in Admin Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant