This repository was archived by the owner on May 14, 2018. It is now read-only.
Update RedirectionStrategy.php#276
Closed
olexp wants to merge 1 commit into
Closed
Conversation
1. Skip redirection for authenticated users It is confusing that user is redirected to login page while he is already authenticated. And usually this leads to another redirection (login redirects to default login page). 2. Add query parameter 'redirect' that defines a URL for redirection after successful login. This parameter is used in ZfcUser by default. Corresponding field (addQueryRedirect) is added to object to control adding.
Contributor
|
This won't be merged:
|
Contributor
|
@olexp consider creating a custom redirect strategy that fits your own domain. Linking ZF-Commons/ZfcUser#487 for reference |
Author
|
The second part seems to be already covered by pull request #225. Sorry about that. Thanks for commenting. I'll add another strategy as you propose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is confusing that user is redirected to login page while he is already authenticated. And usually this leads to another redirection (login redirects to default login page).
This parameter is used in ZfcUser by default. Corresponding field (addQueryRedirect) is added to object to control adding.