Reduce debug logging noise#3036
Merged
Merged
Conversation
…, serial, telerik
Collaborator
Author
|
improving issue raised in #2446 |
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary+ 2 improvements 🚀
24 unchanged ✅🔍 Significant Changes (>10%)
🐍 Python Version 3.11.15 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3036 +/- ##
=====================================
- Coverage 90% 90% -0%
=====================================
Files 444 444
Lines 38338 38319 -19
=====================================
- Hits 34284 34262 -22
- Misses 4054 4057 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # bbot/core/helpers/diff.py # bbot/modules/base.py
ausmaster
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts debug-log noise from a few high-volume sources. The biggest wins are in module-specific code; the core event pipeline is touched only where lines were redundant with adjacent ones.
HttpCompare (
diff.py): drop per-comparison "status code different", "headers different", "body different", "ignored header removed", "switching to text parsing".Serial submodule: drop 4 routine per-payload debugs (baseline match, probe result, "potential finding", "500 or body match"). Keep the useful ones (HttpCompareError, header-only diffs, unexpected status, transient baseline, error string detection).
Paramminer headers: log
binary_searchentry only on the top-level call (not every recursion — ~14k lines), and drop the per-word "Adding to wordlist".Telerik: remove the stray
self.debug(root_tool_path)line.Event pipeline: only the lines whose info was duplicated by an adjacent log are removed —
Got {event} from {module}(×2, duplicated byHandling {event} from {module}),{event} passed post-check(only the failure case is useful, which is already logged),Queueing {event} because {reason}(accept-side reason is rarely meaningful),Forwarding {event}(pairs trivially withIntercepting), andNot intercepting … precheck failed(mostly "watched_events didn't match" at huge volume).Finished handling,Not queueing, andNot intercepting … postcheck failedare kept.