Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactored DB Update #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blebelo merged 1 commit into from
Jan 28, 2026
Merged

Refactored DB Update #29

blebelo merged 1 commit into from
Jan 28, 2026

Conversation

@blebelo
Copy link
Owner

@blebelo blebelo commented Jan 28, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Enhanced continuous integration and deployment pipeline configuration to streamline build processes and improve reliability of database initialization steps.
    • Updated and pinned build tool versions to ensure consistency and compatibility across different deployment environments.
    • Refined deployment pipeline execution for improved cross-platform support and maintainability.

✏️ Tip: You can customize this high-level summary in your review settings.

@blebelo blebelo self-assigned this Jan 28, 2026
@vercel
Copy link

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
moipone Ready Ready Preview, Comment Jan 28, 2026 6:50pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2026 •
edited
Loading

Walkthrough

This pull request updates the CI/CD workflow configuration to enhance tool reliability and build robustness. Changes include splitting the test script into separate steps, pinning EF Core CLI to version 10.0.1, and updating the database update command with an explicit startup project path.

Changes

Cohort / File(s) Summary
CI/CD Workflow Updates
.github/workflows/ci-cd.yml		 Split test execution into separate cd and dotnet test commands; pinned EF Core CLI tool to version 10.0.1 instead of generic install; updated database update command to use explicit --startup-project parameter pointing to ../Moipone.PublicSite.HttpApi.Host; minor formatting adjustments to deploy step

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • #25: Updates the same CI/CD workflow file and modifies the dotnet-ef database update invocation with similar structural changes.

Suggested reviewers

  • mblebelo

Poem

🐰 Tools pinned, paths set clear,
EF Core's version we hold dear,
Steps split and staged just right,
CI/CD runs true day and night! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Refactored DB Update' directly corresponds to the main changes in the pull request, which involve refactoring the database update step in the CI/CD workflow by updating EF Core CLI installation, splitting commands, and using cross-platform dotnet-ef with explicit startup project configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot requested a review from mblebelo January 28, 2026 18:51
mblebelo
mblebelo approved these changes Jan 28, 2026
View reviewed changes
Copy link
Collaborator

@mblebelo mblebelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks passed and conversations resolved ✅

coderabbitai[bot]
coderabbitai bot reviewed Jan 28, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/ci-cd.yml (1)

64-85: CRITICAL: Production database credentials exposed in version control—rotate immediately.

The repository contains plaintext production database credentials in aspnet-core/src/Moipone.PublicSite.Web.Host/appsettings.json (PostgreSQL username=benny with plaintext password). This file is committed to version control and must be remediated:

  1. Immediately rotate the exposed database credentials (Render.com PostgreSQL).
  2. Remove hardcoded credentials from all appsettings files.
  3. Fix the workflow configuration issue: The DbContextFactory does not read the ASPNETCORE_ENVIRONMENT variable when selecting which config file to load. It always loads the default appsettings.json. The factory must pass the environment name to AppConfigurations.Get():
var configuration = AppConfigurations.Get(
    WebContentDirectoryFinder.CalculateContentRootFolder(),
+   Environment.GetEnvironmentVariable("ASPNETCORE_ENVIRONMENT")
);

  1. Verify the startup project path in the workflow. The path ../Moipone.PublicSite.HttpApi.Host does not exist; the projects in aspnet-core/src/ are: Application, Core, EntityFrameworkCore, Migrator, Web.Core, and Web.Host.

  2. Use GitHub Secrets or environment-based configuration for production credentials instead of storing them in appsettings files.

🤖 Fix all issues with AI agents 
In @.github/workflows/ci-cd.yml:
- Around line 115-118: The Deploy application step's curl invocation currently
won't fail on HTTP 4xx/5xx responses; update the curl command used in the
"Deploy application" job to include the --fail flag (optionally with
-sS/--show-error for clearer output) so the GitHub Actions step fails when the
webhook returns an HTTP error; modify the curl invocation referenced as the
deployment command in that step accordingly.

@blebelo blebelo merged commit de4b3a0 into main Jan 28, 2026
9 checks passed
mblebelo
mblebelo approved these changes Jan 28, 2026
View reviewed changes
Copy link
Collaborator

@mblebelo mblebelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks passed and conversations resolved ✅

@coderabbitai coderabbitai bot mentioned this pull request Jan 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@mblebelo mblebelo mblebelo approved these changes

@codespace-cloudmaindesk codespace-cloudmaindesk Awaiting requested review from codespace-cloudmaindesk

Assignees

@blebelo blebelo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blebelo @mblebelo